From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Mon, 09 Jan 2006 19:47:42 +0000 Subject: Re: [KJ] linux-2.6.15-rc7/drivers/pci/syscall.c Message-Id: <20060109194742.GA24281@kroah.com> MIME-Version: 1 Content-Type: multipart/mixed; boundary="===============31474233821043951==" List-Id: References: <200601091138.03704.cneira@srb.cl> In-Reply-To: <200601091138.03704.cneira@srb.cl> To: kernel-janitors@vger.kernel.org --===============31474233821043951== Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jan 09, 2006 at 12:29:32PM -0700, Matthew Wilcox wrote: > On Mon, Jan 09, 2006 at 11:12:01AM -0800, Greg KH wrote: > > On Mon, Jan 09, 2006 at 08:02:19PM +0100, Jesper Juhl wrote: > > > On 1/9/06, Greg KH wrote: > > > > On Mon, Jan 09, 2006 at 11:38:03AM +0000, carlos neira wrote: > > > > > Greetings : > > > > > > > > > > patch :linux-2.6.15-rc7/drivers/pci/syscall.c > > > > > > > > > > replaced a lock_kernel with spinlocks , compile tested ok > > > > > > > > What arch did you compile this for? > > > > > > > > And why remove the lock_kernel calls here, are they hurting anything? > > > > "over time, if it makes sense to do so." > > > > For this specific example, the code should be converted to the kthread > > api, which would remove these instances. > > I think you're confused with which patch is being commented on. The locks > around daemonize() should be converted to kthread(), but this patch is > for the PCI syscalls. As I said in a recent post to linux-pci, I think > they can be deleted without bad effect. Ugh, yeah, sorry, -ETOOMANYPATCHES And yes, I think they can probably be deleted, but not replaced with a spinlock like was done here. thanks, greg k-h --===============31474233821043951== Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline _______________________________________________ Kernel-janitors mailing list Kernel-janitors@lists.osdl.org https://lists.osdl.org/mailman/listinfo/kernel-janitors --===============31474233821043951==--