From: Mark Fasheh <mark.fasheh@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2: actually free hb set on cluster removal
Date: Mon, 9 Jan 2006 13:45:01 -0800 [thread overview]
Message-ID: <20060109214501.GG3313@ca-server1.us.oracle.com> (raw)
In-Reply-To: <20060109174235.GB25744@locomotive.unixthugs.org>
Hi,
On Mon, Jan 09, 2006 at 12:42:35PM -0500, Jeff Mahoney wrote:
> Since heartbeat threads are stopped when the individual heartbeat sets are
> removed, this just cleans up the allocation.
Yes, it seems we're leaking memory there.
> + o2hb_free_hb_set(cluster->cl_group.default_groups[1]);
> for (i = 0; cluster->cl_group.default_groups[i]; i++) {
> killme = &cluster->cl_group.default_groups[i]->cg_item;
> cluster->cl_group.default_groups[i] = NULL;
What about the for loop on the next line? Won't that try to access memory
freed in the call to o2hb_free_hb_set(...)?
--Mark
--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh at oracle.com
next prev parent reply other threads:[~2006-01-09 21:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-09 17:42 [Ocfs2-devel] [PATCH] ocfs2: actually free hb set on cluster removal Jeff Mahoney
2006-01-09 21:45 ` Mark Fasheh [this message]
2006-01-09 22:34 ` Jeff Mahoney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060109214501.GG3313@ca-server1.us.oracle.com \
--to=mark.fasheh@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.