From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincent Hanquez Subject: Re: smp_processor_id() missing when compiling linux-2.6-xen.hg without SMP Date: Mon, 9 Jan 2006 23:32:31 +0100 Message-ID: <20060109223231.GA32395@snarc.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jacob Gorm Hansen Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Tue, Jan 03, 2006 at 11:20:57AM +0100, Jacob Gorm Hansen wrote: > I found I needed the patch to arch/i386/kernel/i8237.c below in order > to compile linux-2.6-xen.hg without SMP, or I smp_processor_id() would > be undefined. I am not sure if this is the correct way to fix the > problem though. This is not the right fix. (hint: i8237 is not modified by xen and has nothing to do with smp) Unfortunately, properly fixing the bug is not trivial. basicly linux/smp.h has to be included before xen's system.h get included for the compilation to succeed. As the i386 kernel doesn't need this assertion, it's not working for i8237.. I tried a couple of things, but they all lead to some funky errors .. -- Vincent Hanquez