Re: [uml-devel] The init_maps bug which cause mem map error

[Blaisorblade <blaisorblade@yahoo.it>]

On Tuesday 10 January 2006 15:14, wang lianwei wrote:
>  There is a bug In file
>     linux/arch/um/kernel/physmem.c  init_mem() functions:

Yep, right...

> *int* *init_maps*(*unsigned* *long* physmem, *unsigned* *long* iomem,
> *unsigned* *long* highmem)
> {
> 	*struct* page *p, *map;
> 	*unsigned* *long* phys_len, phys_pages, highmem_len, highmem_pages;
> 	*unsigned* *long* iomem_len, iomem_pages, total_len, total_pages;
> 	*int* i;

(What happened to these bad "*" guys ;-) ? )

> 	phys_pages = physmem >> PAGE_SHIFT;
> 	phys_len = phys_pages * *sizeof*(*struct* page);

> 	iomem_pages = iomem >> PAGE_SHIFT;
> 	iomem_len = iomem_pages * *sizeof*(*struct* page);

> 	highmem_pages = highmem >> PAGE_SHIFT;
> 	highmem_len = highmem_pages * *sizeof*(*struct* page);

> 	total_pages = phys_pages + iomem_pages + highmem_pages;

> 	total_len = phys_len + iomem_pages + highmem_len;

> this line should be

That line should be the below one, right (it wasn't clear the line you were 
correcting, I later grasped it)? I think you're fully right (and I've never 
seen iomem working very well, so I tend to agree).

> total_len = phys_len + iomem_len + highmem_len;

Remember people: never compare apples with bananas (or whatever). Thanks for 
the note. It's the first patch on my queue.

>  <http://cvs.sourceforge.net/viewcvs.py/user-mode-linux/linux/#dirlist>

-- 
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894)
http://www.user-mode-linux.org/~blaisorblade

	
	
		
___________________________________ 
Yahoo! Messenger with Voice: chiama da PC a telefono a tariffe esclusive 
http://it.messenger.yahoo.com



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel