All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Andrey Borzenkov <arvidjaar@mail.ru>
Cc: Chuck Ebbert <76306.1226@compuserve.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]trivial: add CDC_RAM to ide-cd capabilities mask
Date: Wed, 11 Jan 2006 10:55:07 +0100	[thread overview]
Message-ID: <20060111095506.GV3389@suse.de> (raw)
In-Reply-To: <E1EwcdM-000LWK-00.arvidjaar-mail-ru@f24.mail.ru>

On Wed, Jan 11 2006, Andrey Borzenkov wrote:
> 
> 
> -----Original Message-----
> From: Jens Axboe <axboe@suse.de>
> To: Andrey Borzenkov <arvidjaar@mail.ru>
> Date: Wed, 11 Jan 2006 10:29:38 +0100
> Subject: Re: [PATCH]trivial: add CDC_RAM to ide-cd capabilities mask
> 
> > 
> > On Wed, Jan 11 2006, Andrey Borzenkov wrote:
> > > 
> > > 
> > > > drive name:             sr0
> > > > drive speed:            1
> > > > drive # of slots:       1
> > > > Can close tray:         1
> > > > Can open tray:          1
> > > > Can lock tray:          1
> > > > Can change speed:       0
> > > > Can select disk:        0
> > > > Can read multisession:  1
> > > > Can read MCN:           1
> > > > Reports media changed:  1
> > > > Can play audio:         1
> > > > Can write CD-R:         0
> > > > Can write CD-RW:        0
> > > > Can read DVD:           0
> > > > Can write DVD-R:        0
> > > > Can write DVD-RAM:      0
> > > > Can read MRW:           1
> > > > Can write MRW:          1
> > > > Can write RAM:          1
> > > > 
> > > > There's no way this drive knows anything about MRW or random-access writing:
> > > > 
> > > ...
> > > > And an ATAPI DVD-ROM also reports (before the above patch):
> > > > 
> > > > Can read MRW:           1
> > > > Can write MRW:          1
> > > > Can write RAM:          1
> > > > 
> > > 
> > > I know. There were patches from Jens for both 2.4 and 2.6 that add MRW
> > > support to ide-cd for sure; may be for sr too, am not sure. Jens, any
> > > reasons for them not in mainstream? Otherwise probably ide-cd and sr should
> > > not announce MRW capabiliies at all, it is too confusing; I'll send a patch
> > > when I am at home.
> > 
> > MRW support is in 2.6 since ages. The MRW flag is only detected on open,
> > so it should disappear from the proc file once you have opened the
> > drive. It has to be done that way, I'm afraid.
> > 
> 
> I see, it is in generic cdrom code, sorry.
> 
> is it possible that drive supports MRW_W without supporting any other write
> method (_R/_RW)? Should not ide-cd/sr - or possibly even cdrom - mask MRW_W
> if they do not support writing at all?

I don't know why anyone would make such a device, but of course it's
possible. Masking MRW if the device can't write sounds like a safe
enough bet, I'll take a patch :)

-- 
Jens Axboe


  reply	other threads:[~2006-01-11  9:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-11  8:24 [PATCH]trivial: add CDC_RAM to ide-cd capabilities mask Chuck Ebbert
2006-01-11  9:23 ` Re[2]: " Andrey Borzenkov
2006-01-11  9:29   ` Jens Axboe
2006-01-11  9:51     ` Re[2]: " Andrey Borzenkov
2006-01-11  9:55       ` Jens Axboe [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-01-09 20:16 Andrey Borzenkov
2006-01-10 10:13 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060111095506.GV3389@suse.de \
    --to=axboe@suse.de \
    --cc=76306.1226@compuserve.com \
    --cc=arvidjaar@mail.ru \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.