From: Matthew Wilcox <matthew@wil.cx>
To: Greg KH <greg@kroah.com>
Cc: Shaohua Li <shaohua.li@intel.com>, Andrew Morton <akpm@osdl.org>,
linux-pci <linux-pci@atrey.karlin.mff.cuni.cz>,
lkml <linux-kernel@vger.kernel.org>,
Rajesh Shah <rajesh.shah@intel.com>
Subject: Re: [PATCH 1/2]MSI(X) save/restore for suspend/resume
Date: Wed, 11 Jan 2006 11:39:47 -0700 [thread overview]
Message-ID: <20060111183947.GD19769@parisc-linux.org> (raw)
In-Reply-To: <20060111155142.GA19828@kroah.com>
On Wed, Jan 11, 2006 at 07:51:42AM -0800, Greg KH wrote:
> On Wed, Jan 11, 2006 at 04:18:22PM +0800, Shaohua Li wrote:
> > +struct pci_cap_saved_state {
> > + struct pci_cap_saved_state *next;
> > + char cap_nr;
> > + u32 data[0];
> > +};
>
> Use the in-kernel list functions instead of creating your own logic for
> a linked list.
BTW, please use the hlist functions, not list_head for this case.
next prev parent reply other threads:[~2006-01-11 18:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-27 2:05 [PATCH 1/2]MSI(X) save/restore for suspend/resume Shaohua Li
2005-12-27 7:55 ` Arjan van de Ven
2005-12-28 1:24 ` Shaohua Li
2005-12-28 8:25 ` Arjan van de Ven
2005-12-28 8:28 ` Shaohua Li
2006-01-04 7:13 ` Andrew Morton
2006-01-05 0:58 ` Shaohua Li
2006-01-10 20:15 ` Greg KH
2006-01-10 20:28 ` Matthew Wilcox
2006-01-11 1:17 ` Shaohua Li
2006-01-11 1:26 ` Greg KH
2006-01-11 8:18 ` Shaohua Li
2006-01-11 15:20 ` Matthew Wilcox
2006-01-11 15:51 ` Greg KH
2006-01-11 18:39 ` Matthew Wilcox [this message]
2006-01-12 2:30 ` Shaohua Li
2006-01-12 2:47 ` Matthew Wilcox
2006-01-12 3:17 ` Shaohua Li
2006-01-12 7:12 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2006-02-08 9:11 Shaohua Li
2006-02-21 5:24 ` Greg KH
2006-02-22 8:13 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060111183947.GD19769@parisc-linux.org \
--to=matthew@wil.cx \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=rajesh.shah@intel.com \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.