Re: [PATCH -mm] mm/rmap.c: don't forget to include module.h

[Adrian Bunk <bunk@stusta.de>]

On Wed, Jan 11, 2006 at 07:57:58PM +0300, Alexey Dobriyan wrote:
>   CC      mm/rmap.o
> mm/rmap.c:235: warning: type defaults to `int' in declaration of `EXPORT_SYMBOL'
> mm/rmap.c:235: warning: parameter names (without types) in function declaration
> mm/rmap.c:235: warning: data definition has no type or storage class
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
> 
>  mm/rmap.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> --- linux-2.6.15-mm3/mm/rmap.c	2006-01-11 19:42:39.000000000 +0300
> +++ linux-2.6.15-mm3-rmap/mm/rmap.c	2006-01-11 19:48:12.000000000 +0300
> @@ -52,6 +52,9 @@
>  #include <linux/init.h>
>  #include <linux/rmap.h>
>  #include <linux/rcupdate.h>
> +#ifdef CONFIG_MIGRATION
> +#include <linux/module.h>
> +#endif
>...

There's no need for an #ifdef.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed