From: Vojtech Pavlik <vojtech@suse.cz>
To: Michael Hanselmann <linux-kernel@hansmi.ch>
Cc: linux-kernel@killerfox.forkbomb.ch, dtor_core@ameritech.net,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
linux-input@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH/RFC?] usb/input: Add support for fn key on Apple PowerBooks
Date: Wed, 11 Jan 2006 22:47:32 +0100 [thread overview]
Message-ID: <20060111214732.GA12014@midnight.suse.cz> (raw)
In-Reply-To: <20060111214351.GF6617@hansmi.ch>
On Wed, Jan 11, 2006 at 10:43:51PM +0100, Michael Hanselmann wrote:
> On Thu, Jan 12, 2006 at 08:41:08AM +1100, Benjamin Herrenschmidt wrote:
> > > Johannes Berg told me he wants to use the fn key alone to switch the
> > > keyboard layout or something. For such uses, the pb_enablefn is there.
>
> Sorry, actually it's called pb_disablefn now.
>
> > What does it do ? Just send a keycode ? That should be unconditionnal.
> > The Fn key should change a keycode always. I don't see why you would
> > that to be off.
>
> No, if that parameter is disabled, it translates key combinations like
> Fn+F1 to KEY_BRIGHTNESSUP. If it's enabled, it only sends KEY_FN.
I believe a better behavior would be to send KEY_FN and then
KEY_BRIGHTNESSUP when enabled and KEY_FN and KEY_F1 when disabled.
--
Vojtech Pavlik
SuSE Labs, SuSE CR
WARNING: multiple messages have this Message-ID (diff)
From: Vojtech Pavlik <vojtech@suse.cz>
To: Michael Hanselmann <linux-kernel@hansmi.ch>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
dtor_core@ameritech.net, linux-kernel@vger.kernel.org,
linux-input@atrey.karlin.mff.cuni.cz, linuxppc-dev@ozlabs.org,
linux-kernel@killerfox.forkbomb.ch
Subject: Re: [PATCH/RFC?] usb/input: Add support for fn key on Apple PowerBooks
Date: Wed, 11 Jan 2006 22:47:32 +0100 [thread overview]
Message-ID: <20060111214732.GA12014@midnight.suse.cz> (raw)
In-Reply-To: <20060111214351.GF6617@hansmi.ch>
On Wed, Jan 11, 2006 at 10:43:51PM +0100, Michael Hanselmann wrote:
> On Thu, Jan 12, 2006 at 08:41:08AM +1100, Benjamin Herrenschmidt wrote:
> > > Johannes Berg told me he wants to use the fn key alone to switch the
> > > keyboard layout or something. For such uses, the pb_enablefn is there.
>
> Sorry, actually it's called pb_disablefn now.
>
> > What does it do ? Just send a keycode ? That should be unconditionnal.
> > The Fn key should change a keycode always. I don't see why you would
> > that to be off.
>
> No, if that parameter is disabled, it translates key combinations like
> Fn+F1 to KEY_BRIGHTNESSUP. If it's enabled, it only sends KEY_FN.
I believe a better behavior would be to send KEY_FN and then
KEY_BRIGHTNESSUP when enabled and KEY_FN and KEY_F1 when disabled.
--
Vojtech Pavlik
SuSE Labs, SuSE CR
next prev parent reply other threads:[~2006-01-11 22:08 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-25 21:20 [PATCH/RFC?] usb/input: Add support for fn key on Apple PowerBooks Michael Hanselmann
2005-12-25 21:20 ` Michael Hanselmann
2005-12-25 21:57 ` Benjamin Herrenschmidt
2005-12-25 21:57 ` Benjamin Herrenschmidt
2005-12-26 4:04 ` Dmitry Torokhov
2005-12-26 4:04 ` Dmitry Torokhov
2005-12-26 5:46 ` Benjamin Herrenschmidt
2005-12-26 5:46 ` Benjamin Herrenschmidt
2006-01-11 21:07 ` Dmitry Torokhov
2006-01-11 21:07 ` Dmitry Torokhov
2006-01-11 21:20 ` Michael Hanselmann
2006-01-11 21:20 ` Michael Hanselmann
2006-01-11 21:34 ` Benjamin Herrenschmidt
2006-01-11 21:34 ` Benjamin Herrenschmidt
2006-01-11 21:38 ` Michael Hanselmann
2006-01-11 21:38 ` Michael Hanselmann
2006-01-11 21:41 ` Benjamin Herrenschmidt
2006-01-11 21:41 ` Benjamin Herrenschmidt
2006-01-11 21:43 ` Michael Hanselmann
2006-01-11 21:43 ` Michael Hanselmann
2006-01-11 21:47 ` Vojtech Pavlik [this message]
2006-01-11 21:47 ` Vojtech Pavlik
2006-01-11 21:50 ` Michael Hanselmann
2006-01-11 21:50 ` Michael Hanselmann
2006-01-11 21:54 ` Benjamin Herrenschmidt
2006-01-11 21:54 ` Benjamin Herrenschmidt
2006-01-11 21:30 ` Benjamin Herrenschmidt
2006-01-11 21:30 ` Benjamin Herrenschmidt
2006-01-11 21:45 ` Vojtech Pavlik
2006-01-11 21:45 ` Vojtech Pavlik
2006-01-11 21:46 ` Michael Hanselmann
2006-01-11 21:46 ` Michael Hanselmann
2006-01-11 23:26 ` Michael Hanselmann
2006-01-11 23:26 ` Michael Hanselmann
2006-01-11 23:41 ` Benjamin Herrenschmidt
2006-01-11 23:41 ` Benjamin Herrenschmidt
2006-01-12 0:08 ` Michael Hanselmann
2006-01-12 0:08 ` Michael Hanselmann
2006-01-13 4:12 ` Dmitry Torokhov
2006-01-13 4:12 ` Dmitry Torokhov
2006-01-13 6:53 ` Michael Hanselmann
2006-01-13 6:53 ` Michael Hanselmann
2006-01-13 7:47 ` Vojtech Pavlik
2006-01-13 7:47 ` Vojtech Pavlik
2006-01-13 22:02 ` Michael Hanselmann
2006-01-13 22:02 ` Michael Hanselmann
2006-01-14 4:58 ` Dmitry Torokhov
2006-01-14 4:58 ` Dmitry Torokhov
2006-01-14 10:41 ` Vojtech Pavlik
2006-01-14 10:41 ` Vojtech Pavlik
2006-01-14 10:57 ` Michael Hanselmann
2006-01-14 10:57 ` Michael Hanselmann
2006-01-13 21:55 ` Benjamin Herrenschmidt
2006-01-13 21:55 ` Benjamin Herrenschmidt
2006-01-13 21:57 ` Benjamin Herrenschmidt
2006-01-13 21:57 ` Benjamin Herrenschmidt
2006-01-13 22:05 ` Dmitry Torokhov
2006-01-13 22:05 ` Dmitry Torokhov
2006-01-13 22:08 ` Dmitry Torokhov
2006-01-13 22:08 ` Dmitry Torokhov
2006-01-13 22:14 ` Benjamin Herrenschmidt
2006-01-13 22:14 ` Benjamin Herrenschmidt
2006-01-13 22:25 ` Dmitry Torokhov
2006-01-13 22:25 ` Dmitry Torokhov
2006-01-12 9:07 ` Vojtech Pavlik
2006-01-12 9:07 ` Vojtech Pavlik
2006-01-12 23:39 ` Michael Hanselmann
2006-01-12 23:39 ` Michael Hanselmann
2006-01-13 1:53 ` Benjamin Herrenschmidt
2006-01-13 1:53 ` Benjamin Herrenschmidt
2005-12-31 23:51 ` Michael Hanselmann
2005-12-31 23:51 ` Michael Hanselmann
2006-01-01 1:33 ` Michael Hanselmann
2006-01-01 1:33 ` Michael Hanselmann
2006-01-01 2:56 ` Benjamin Herrenschmidt
2006-01-01 2:56 ` Benjamin Herrenschmidt
2006-01-01 3:03 ` Michael Hanselmann
2006-01-01 3:03 ` Michael Hanselmann
2006-01-01 6:09 ` Benjamin Herrenschmidt
2006-01-01 6:09 ` Benjamin Herrenschmidt
2006-01-02 22:46 ` Michael Hanselmann
2006-01-02 22:46 ` Michael Hanselmann
2006-01-03 2:29 ` Ben Collins
2006-01-03 2:29 ` Ben Collins
2006-01-03 19:14 ` Michael Hanselmann
2006-01-03 19:14 ` Michael Hanselmann
2006-01-03 19:18 ` Ben Collins
2006-01-03 19:18 ` Ben Collins
2006-01-03 19:25 ` Michael Hanselmann
2006-01-03 19:25 ` Michael Hanselmann
2006-01-02 12:06 ` Stelian Pop
2006-01-02 12:06 ` Stelian Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060111214732.GA12014@midnight.suse.cz \
--to=vojtech@suse.cz \
--cc=dtor_core@ameritech.net \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@hansmi.ch \
--cc=linux-kernel@killerfox.forkbomb.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.