From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hansmi.home.forkbomb.ch (hansmi.home.forkbomb.ch [213.144.146.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "hansmi.home.forkbomb.ch", Issuer "hansmi.home.forkbomb.ch" (not verified)) by ozlabs.org (Postfix) with ESMTP id 7CA36689E1 for ; Thu, 12 Jan 2006 08:50:12 +1100 (EST) Date: Wed, 11 Jan 2006 22:50:07 +0100 From: Michael Hanselmann To: Vojtech Pavlik Message-ID: <20060111215007.GH6617@hansmi.ch> References: <20051225212041.GA6094@hansmi.ch> <200512252304.32830.dtor_core@ameritech.net> <1135575997.14160.4.camel@localhost.localdomain> <20060111212056.GC6617@hansmi.ch> <1137015258.5138.20.camel@localhost.localdomain> <20060111213805.GE6617@hansmi.ch> <1137015669.5138.22.camel@localhost.localdomain> <20060111214351.GF6617@hansmi.ch> <20060111214732.GA12014@midnight.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20060111214732.GA12014@midnight.suse.cz> Cc: linux-kernel@killerfox.forkbomb.ch, dtor_core@ameritech.net, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, linux-input@atrey.karlin.mff.cuni.cz Subject: Re: [PATCH/RFC?] usb/input: Add support for fn key on Apple PowerBooks List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Jan 11, 2006 at 10:47:32PM +0100, Vojtech Pavlik wrote: > > No, if that parameter is disabled, it translates key combinations like > > Fn+F1 to KEY_BRIGHTNESSUP. If it's enabled, it only sends KEY_FN. > I believe a better behavior would be to send KEY_FN and then > KEY_BRIGHTNESSUP when enabled and KEY_FN and KEY_F1 when disabled. That's done. It sends KEY_FN as any other key. If a key is pressed while the fn key is pressed, it uses the table to look up the new code. Releasing is also done with the corresponding keycodes. Greets, Michael From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750930AbWAKVuL (ORCPT ); Wed, 11 Jan 2006 16:50:11 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750952AbWAKVuL (ORCPT ); Wed, 11 Jan 2006 16:50:11 -0500 Received: from hansmi.home.forkbomb.ch ([213.144.146.165]:27421 "EHLO hansmi.home.forkbomb.ch") by vger.kernel.org with ESMTP id S1750951AbWAKVuK (ORCPT ); Wed, 11 Jan 2006 16:50:10 -0500 Date: Wed, 11 Jan 2006 22:50:07 +0100 From: Michael Hanselmann To: Vojtech Pavlik Cc: Benjamin Herrenschmidt , dtor_core@ameritech.net, linux-kernel@vger.kernel.org, linux-input@atrey.karlin.mff.cuni.cz, linuxppc-dev@ozlabs.org, linux-kernel@killerfox.forkbomb.ch Subject: Re: [PATCH/RFC?] usb/input: Add support for fn key on Apple PowerBooks Message-ID: <20060111215007.GH6617@hansmi.ch> References: <20051225212041.GA6094@hansmi.ch> <200512252304.32830.dtor_core@ameritech.net> <1135575997.14160.4.camel@localhost.localdomain> <20060111212056.GC6617@hansmi.ch> <1137015258.5138.20.camel@localhost.localdomain> <20060111213805.GE6617@hansmi.ch> <1137015669.5138.22.camel@localhost.localdomain> <20060111214351.GF6617@hansmi.ch> <20060111214732.GA12014@midnight.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060111214732.GA12014@midnight.suse.cz> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 11, 2006 at 10:47:32PM +0100, Vojtech Pavlik wrote: > > No, if that parameter is disabled, it translates key combinations like > > Fn+F1 to KEY_BRIGHTNESSUP. If it's enabled, it only sends KEY_FN. > I believe a better behavior would be to send KEY_FN and then > KEY_BRIGHTNESSUP when enabled and KEY_FN and KEY_F1 when disabled. That's done. It sends KEY_FN as any other key. If a key is pressed while the fn key is pressed, it uses the table to look up the new code. Releasing is also done with the corresponding keycodes. Greets, Michael