From: Ingo Molnar <mingo@elte.hu>
To: "David S. Miller" <davem@davemloft.net>
Cc: pavel@suse.cz, arjan@infradead.org, akpm@osdl.org, ak@suse.de,
linux-kernel@vger.kernel.org, sct@redhat.com
Subject: Re: 2.6.15-git7 oopses in ext3 during LTP runs
Date: Thu, 12 Jan 2006 01:30:58 +0100 [thread overview]
Message-ID: <20060112003058.GA2681@elte.hu> (raw)
In-Reply-To: <20060111.144422.48199200.davem@davemloft.net>
* David S. Miller <davem@davemloft.net> wrote:
> From: Pavel Machek <pavel@suse.cz>
> Date: Wed, 11 Jan 2006 23:40:13 +0100
>
> > likely is the evil part here. What about this? Should make this bug
> > impossible to do....
> >
> > Signed-off-by: Pavel Machek <pavel@suse.cz>
>
> This doesn't let you do:
>
> if (likely(y) || unlikely(x))
hm, why not? It will expand to:
if ((__builtin_expect(!!(y), 1)) || (__builtin_expect(!!(x), 0)))
which seems correct to me. Pavel only added extra parantheses, to make
the simple case more readable.
Ingo
next prev parent reply other threads:[~2006-01-12 0:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-11 20:26 2.6.15-git7 oopses in ext3 during LTP runs Andi Kleen
2006-01-11 20:46 ` Andrew Morton
2006-01-11 20:55 ` Arjan van de Ven
2006-01-11 21:07 ` Andrew Morton
2006-01-11 21:27 ` Arjan van de Ven
2006-01-11 22:19 ` Ingo Molnar
2006-01-11 22:40 ` Pavel Machek
2006-01-11 22:44 ` David S. Miller
2006-01-12 0:30 ` Ingo Molnar [this message]
2006-01-11 22:47 ` Jesper Juhl
2006-01-12 8:51 ` Pavel Machek
2006-01-12 0:55 ` 2.6.15-git7 oopses in ext3 during LTP runs II - more problems Andi Kleen
2006-01-12 1:14 ` Andrew Morton
2006-01-12 1:25 ` Andi Kleen
2006-01-11 21:25 ` 2.6.15-git7 oopses in ext3 during LTP runs Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060112003058.GA2681@elte.hu \
--to=mingo@elte.hu \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=sct@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.