All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grant Grundler <grundler@parisc-linux.org>
To: Mark Maule <maule@sgi.com>
Cc: linuxppc64-dev@ozlabs.org, linux-pci@atrey.karlin.mff.cuni.cz,
	linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
	Tony Luck <tony.luck@intel.com>,
	gregkh@suse.de
Subject: Re: [PATCH 1/3] msi vector targeting abstractions
Date: Thu, 12 Jan 2006 04:53:41 +0000	[thread overview]
Message-ID: <20060112050243.GC332@colo.lackof.org> (raw)
In-Reply-To: <20060111155256.12460.26048.32596@attica.americas.sgi.com>

On Wed, Jan 11, 2006 at 09:52:56AM -0600, Mark Maule wrote:
> Abstract portions of the MSI core for platforms that do not use standard
> APIC interrupt controllers.  This is implemented through a new arch-specific
> msi setup routine, and a set of msi ops which can be set on a per platform
> basis.
...
> Index: linux-maule/drivers/pci/msi.c
...
> +	if ((status = msi_arch_init()) < 0) {

Willy told me I should always complain about assignment in if() statements :)

Greg, I volunteer to submit a patch to fix all occurances in pci/msi.c
including the one above.  I can prepare that this weekend on my own time.
Is that ok?

grant

WARNING: multiple messages have this Message-ID (diff)
From: Grant Grundler <grundler@parisc-linux.org>
To: Mark Maule <maule@sgi.com>
Cc: linuxppc64-dev@ozlabs.org, linux-pci@atrey.karlin.mff.cuni.cz,
	linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
	Tony Luck <tony.luck@intel.com>,
	gregkh@suse.de
Subject: Re: [PATCH 1/3] msi vector targeting abstractions
Date: Wed, 11 Jan 2006 22:02:43 -0700	[thread overview]
Message-ID: <20060112050243.GC332@colo.lackof.org> (raw)
In-Reply-To: <20060111155256.12460.26048.32596@attica.americas.sgi.com>

On Wed, Jan 11, 2006 at 09:52:56AM -0600, Mark Maule wrote:
> Abstract portions of the MSI core for platforms that do not use standard
> APIC interrupt controllers.  This is implemented through a new arch-specific
> msi setup routine, and a set of msi ops which can be set on a per platform
> basis.
...
> Index: linux-maule/drivers/pci/msi.c
...
> +	if ((status = msi_arch_init()) < 0) {

Willy told me I should always complain about assignment in if() statements :)

Greg, I volunteer to submit a patch to fix all occurances in pci/msi.c
including the one above.  I can prepare that this weekend on my own time.
Is that ok?

grant

  parent reply	other threads:[~2006-01-12  4:53 UTC|newest]

Thread overview: 162+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-22 17:15 [PATCH 0/3] msi abstractions and support for altix Mark Maule
2005-12-22 17:15 ` Mark Maule
2005-12-22 17:15 ` [PATCH 1/3] msi vector targeting abstractions Mark Maule
2005-12-22 17:15   ` Mark Maule
2005-12-22 19:58   ` Greg KH
2005-12-22 19:58     ` Greg KH
2005-12-22 20:09     ` Mark Maule
2005-12-22 20:09       ` Mark Maule
2005-12-22 20:19       ` Greg KH
2005-12-22 20:19         ` Greg KH
2006-01-12 16:55   ` Joe Perches
2006-01-12 17:17   ` Greg KH
2006-01-14  7:34   ` Grant Grundler
2005-12-22 17:15 ` [PATCH 2/3] per-platform IA64_{FIRST,LAST}_DEVICE_VECTOR definitions Mark Maule
2005-12-22 17:15   ` Mark Maule
2005-12-22 20:01   ` Greg KH
2005-12-22 20:01     ` Greg KH
2005-12-22 20:06     ` Mark Maule
2005-12-22 20:06       ` Mark Maule
2005-12-22 17:15 ` [PATCH 2/3] altix: msi support Mark Maule
2005-12-22 17:15   ` Mark Maule
2005-12-22 20:15 ` [PATCH 0/3] msi abstractions and support for altix Mark Maule
2005-12-22 20:15   ` Mark Maule
2005-12-22 20:15   ` [PATCH 1/3] msi vector targeting abstractions Mark Maule
2005-12-22 20:15     ` Mark Maule
2006-01-03 22:39     ` Grant Grundler
2006-01-03 22:39       ` Grant Grundler
2006-01-03 23:50       ` Mark Maule
2006-01-03 23:50         ` Mark Maule
2006-01-04  0:20         ` Grant Grundler
2006-01-04  0:20           ` Grant Grundler
2006-01-04  0:27           ` Greg KH
2006-01-04  0:27             ` Greg KH
2006-01-04  3:52             ` Mark Maule
2006-01-04  3:52               ` Mark Maule
2005-12-22 20:15   ` [PATCH 2/3] per-platform IA64_{FIRST,LAST}_DEVICE_VECTOR definitions Mark Maule
2005-12-22 20:15     ` Mark Maule
2006-01-04  0:01     ` Grant Grundler
2006-01-04  0:01       ` Grant Grundler
2005-12-22 20:16   ` [PATCH 2/3] altix: msi support Mark Maule
2005-12-22 20:16     ` Mark Maule
2005-12-22 20:22   ` [PATCH 0/3] msi abstractions and support for altix Greg KH
2005-12-22 20:22     ` Greg KH
2005-12-22 20:26     ` Mark Maule
2005-12-22 20:26       ` Mark Maule
2005-12-22 20:34       ` Greg KH
2005-12-22 20:34         ` Greg KH
2005-12-22 20:38         ` Mark Maule
2005-12-22 20:38           ` Mark Maule
2005-12-22 20:50           ` Matthew Wilcox
2005-12-22 20:50             ` Matthew Wilcox
2006-01-03  3:22             ` Mark Maule
2006-01-03  3:22               ` Mark Maule
2006-01-03  6:07               ` Greg KH
2006-01-03  6:07                 ` Greg KH
2006-01-10 17:00                 ` Mark Maule
2006-01-10 17:00                   ` Mark Maule
2006-01-10 17:03                   ` Christoph Hellwig
2006-01-10 17:11                     ` Greg KH
2006-01-10 17:11                       ` Greg KH
2005-12-22 21:44           ` Greg KH
2005-12-22 21:44             ` Greg KH
2005-12-23 15:32             ` Mark Maule
2005-12-23 15:32               ` Mark Maule
2005-12-23 16:32               ` Greg KH
2005-12-23 16:32                 ` Greg KH
2006-01-11 15:52 ` Mark Maule
2006-01-11 15:52   ` Mark Maule
2006-01-11 15:52   ` [PATCH 1/3] msi vector targeting abstractions Mark Maule
2006-01-11 15:52     ` Mark Maule
2006-01-11 20:21     ` Greg KH
2006-01-11 20:21       ` Greg KH
2006-01-11 20:49       ` Mark Maule
2006-01-11 20:49         ` Mark Maule
2006-01-11 20:57         ` Greg KH
2006-01-11 20:57           ` Greg KH
2006-01-12  4:53     ` Grant Grundler [this message]
2006-01-12  5:02       ` Grant Grundler
2006-01-12  5:36       ` Greg KH
2006-01-12  5:36         ` Greg KH
2006-01-12  5:47       ` Paul Mackerras
2006-01-12  5:47         ` Paul Mackerras
2006-01-12  7:33         ` Grant Grundler
2006-01-12  7:33           ` Grant Grundler
2006-01-11 15:53   ` [PATCH 2/3] per-platform IA64_{FIRST,LAST}_DEVICE_VECTOR definitions Mark Maule
2006-01-11 15:53     ` Mark Maule
2006-01-11 15:53   ` [PATCH 2/3] altix: msi support Mark Maule
2006-01-11 15:53     ` Mark Maule
2006-01-11 22:16 ` [PATCH 0/3] msi abstractions and support for altix Mark Maule
2006-01-11 22:16   ` Mark Maule
2006-01-11 22:16   ` [PATCH 1/3] msi vector targeting abstractions Mark Maule
2006-01-11 22:16     ` Mark Maule
2006-01-11 22:16   ` [PATCH 2/3] per-platform IA64_{FIRST,LAST}_DEVICE_VECTOR definitions Mark Maule
2006-01-11 22:16     ` Mark Maule
2006-01-11 22:16   ` [PATCH 3/3] altix: msi support Mark Maule
2006-01-11 22:16     ` Mark Maule
2006-01-19 19:46 ` [PATCH 0/3] msi abstractions and support for altix Mark Maule
2006-01-19 19:46   ` Mark Maule
2006-01-19 19:46   ` [PATCH 1/3] msi vector targeting abstractions Mark Maule
2006-01-19 19:46     ` Mark Maule
2006-01-20  2:15     ` Greg KH
2006-01-20  2:15       ` Greg KH
2006-01-19 19:46   ` [PATCH 2/3] per-platform IA64_{FIRST,LAST}_DEVICE_VECTOR definitions Mark Maule
2006-01-19 19:46     ` Mark Maule
2006-01-19 19:47   ` [PATCH 3/3] altix: msi support Mark Maule
2006-01-19 19:47     ` Mark Maule
2006-02-04  4:14     ` Altix SN2 2.6.16-rc1-mm5 build breakage (was: msi support) Paul Jackson
2006-02-04  4:14       ` Paul Jackson
2006-02-04  4:25       ` Andrew Morton
2006-02-04  4:25         ` Andrew Morton
2006-02-04  4:27         ` Andrew Morton
2006-02-04  4:27           ` Andrew Morton
2006-02-04  4:42           ` Mark Maule
2006-02-04  4:42             ` Mark Maule
2006-02-04  5:08             ` Andrew Morton
2006-02-04  5:08               ` Andrew Morton
2006-02-23  0:50           ` Paul Jackson
2006-02-23  0:50             ` Paul Jackson
2006-02-23  1:01             ` Andrew Morton
2006-02-23  1:01               ` Andrew Morton
2006-03-21 14:34 ` [PATCH 0/3] msi abstractions and support for altix Mark Maule
2006-03-21 14:34   ` Mark Maule
2006-03-21 14:34   ` Mark Maule
2006-03-21 14:34   ` [PATCH 1/3] msi vector targeting abstractions Mark Maule
2006-03-21 14:34     ` Mark Maule
2006-03-21 14:34     ` Mark Maule
2006-03-21 16:29     ` Jun'ichi Nomura
2006-03-21 16:29       ` Jun'ichi Nomura
2006-03-21 16:29       ` Jun'ichi Nomura
2006-03-21 16:38       ` Andreas Schwab
2006-03-21 16:38         ` Andreas Schwab
2006-03-21 16:38         ` Andreas Schwab
2006-03-21 19:14         ` Mark Maule
2006-03-21 19:14           ` Mark Maule
2006-03-21 19:14           ` Mark Maule
2006-03-21 19:23           ` Jun'ichi Nomura
2006-03-21 19:23             ` Jun'ichi Nomura
2006-03-21 19:23             ` Jun'ichi Nomura
2006-03-21 19:38             ` Mark Maule
2006-03-21 19:38               ` Mark Maule
2006-03-21 19:38               ` Mark Maule
2006-03-21 14:34   ` [PATCH 2/3] per-platform IA64_{FIRST,LAST}_DEVICE_VECTOR definitions Mark Maule
2006-03-21 14:34     ` Mark Maule
2006-03-21 14:34     ` Mark Maule
2006-03-21 14:34   ` [PATCH 3/3] altix: msi support Mark Maule
2006-03-21 14:34     ` Mark Maule
2006-03-21 14:34     ` Mark Maule
2006-03-21 21:53   ` [PATCH 0/3] msi abstractions and support for altix David S. Miller
2006-03-21 21:53     ` David S. Miller
2006-03-21 21:53     ` David S. Miller
2006-03-29  2:31 ` Mark Maule
2006-03-29  2:31   ` Mark Maule
2006-03-29  2:31   ` Mark Maule
2006-03-29  2:31   ` [PATCH 1/3] msi vector targeting abstractions Mark Maule
2006-03-29  2:31     ` Mark Maule
2006-03-29  2:31     ` Mark Maule
2006-03-29  2:31   ` [PATCH 2/3] per-platform IA64_{FIRST,LAST}_DEVICE_VECTOR definitions Mark Maule
2006-03-29  2:31     ` Mark Maule
2006-03-29  2:31     ` Mark Maule
2006-03-29  2:31   ` [PATCH 3/3] altix: msi support Mark Maule
2006-03-29  2:31     ` Mark Maule
2006-03-29  2:31     ` Mark Maule

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060112050243.GC332@colo.lackof.org \
    --to=grundler@parisc-linux.org \
    --cc=gregkh@suse.de \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=linuxppc64-dev@ozlabs.org \
    --cc=maule@sgi.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.