From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Mason Subject: Re: [PATCH] Fix ext2 error reporting on fsync Date: Thu, 12 Jan 2006 08:58:50 -0500 Message-ID: <200601120858.53061.mason@suse.com> References: <20060111174302.GD16728@atrey.karlin.mff.cuni.cz> <20060112102036.GC8920@atrey.karlin.mff.cuni.cz> <20060112035217.1f4331c5.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Jan Kara , linux-fsdevel@vger.kernel.org Return-path: Received: from cantor2.suse.de ([195.135.220.15]:37356 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S1030308AbWALN66 (ORCPT ); Thu, 12 Jan 2006 08:58:58 -0500 To: Andrew Morton In-Reply-To: <20060112035217.1f4331c5.akpm@osdl.org> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thursday 12 January 2006 06:52, Andrew Morton wrote: > hm, yes, try_to_free_buffers() against a blockdev page is a problem. But I > think it's fixable. > > In the second loop of drop_buffers(), if we find a bh which had a write > error we need to set AS_EIO on the address_space which is interested in > this buffer. > > That address_space is pinned by a) the fact that it has buffers at > ->private_list and b) we hold the blockdev mapping's private_lock. > > The only problem is actually _finding_ the address_space which is > interested in this buffer_head. Looks like we'd need a backpointer in the > buffer_head. Hmmm, how does this work with two concurrent fsyncs on different files? -chris