From: Benjamin LaHaise <bcrl@kvack.org>
To: Oliver Neukum <oliver@neukum.org>,
linux-usb-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: need for packed attribute
Date: Thu, 12 Jan 2006 13:32:40 -0500 [thread overview]
Message-ID: <20060112183239.GA6096@kvack.org> (raw)
In-Reply-To: <20060106183846.GF16093@flint.arm.linux.org.uk>
On Fri, Jan 06, 2006 at 06:38:46PM +0000, Russell King wrote:
> > /* All standard descriptors have these 2 fields at the beginning */
> > struct usb_descriptor_header {
> > __u8 bLength;
> > __u8 bDescriptorType;
> > };
>
> sizeof(struct usb_descriptor_header) will be 4 on ARM. If this
> concerns you, you need to pack the structure thusly:
Interesting. Perhaps we should add -Wpadded to CFLAGS in order to remind
people, although that might take a fair bit of work to clean up existing
structure definitions.
-ben
--
"You know, I've seen some crystals do some pretty trippy shit, man."
Don't Email: <dont@kvack.org>.
next prev parent reply other threads:[~2006-01-12 18:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-06 18:15 need for packed attribute Oliver Neukum
2006-01-06 18:38 ` Russell King
2006-01-12 18:32 ` Benjamin LaHaise [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-01-12 12:27 Mikael Pettersson
2006-01-12 13:47 ` Russell King
2006-01-12 13:53 ` Russell King
2006-01-12 16:30 ` Mikael Pettersson
2006-01-12 16:46 ` Russell King
2006-01-12 17:20 ` Pete Zaitcev
2006-01-12 17:26 ` Russell King
2006-01-12 17:36 ` Pete Zaitcev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060112183239.GA6096@kvack.org \
--to=bcrl@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.