From: Adrian Bunk <bunk@stusta.de>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Sam Ravnborg <sam@ravnborg.org>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: [2.6 patch] i386: remove gcc version check for CONFIG_REGPARM
Date: Fri, 13 Jan 2006 00:18:33 +0100 [thread overview]
Message-ID: <20060112231833.GC29663@stusta.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0601100821440.4939@g5.osdl.org>
On Tue, Jan 10, 2006 at 08:27:57AM -0800, Linus Torvalds wrote:
>
>
> On Mon, 9 Jan 2006, Sam Ravnborg wrote:
> >
> > Please pull from:
> > ssh://master.kernel.org/pub/scm/linux/kernel/git/sam/kbuild.git
>
> Ok, pulled.
>
> However, fixing up a trivial conflict in i386/Makefile, I noticed this:
>
> cflags-$(CONFIG_REGPARM) += $(shell if [ $(call cc-version) -ge 0300 ] ; then \
> echo "-mregparm=3"; fi ;)
>
> and it strikes me that this is WRONG.
>
> It's wrong for some subtle reasons: it means that CONFIG_REGPARM is set
> whether or not it is actually _used_, which means that anybody who depends
> on CONFIG_REGPARM in the sources is just screwed.
>...
The change from Sam's tree conflicted with my patch to completely remove
the version check since we do no longer support any gcc < 3.0.
Patch below.
> Linus
cu
Adrian
<-- snip -->
Since we do no longer support any gcc < 3.0, there's no need to check
for it..
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.15-mm3-full/arch/i386/Makefile.old 2006-01-13 00:04:09.000000000 +0100
+++ linux-2.6.15-mm3-full/arch/i386/Makefile 2006-01-13 00:05:09.000000000 +0100
@@ -37,10 +37,7 @@
# CPU-specific tuning. Anything which can be shared with UML should go here.
include $(srctree)/arch/i386/Makefile.cpu
-# -mregparm=3 works ok on gcc-3.0 and later
-#
-cflags-$(CONFIG_REGPARM) += $(shell if [ $(call cc-version) -ge 0300 ] ; then \
- echo "-mregparm=3"; fi ;)
+cflags-$(CONFIG_REGPARM) += -mregparm=3
# Disable unit-at-a-time mode on pre-gcc-4.0 compilers, it makes gcc use
# a lot more stack due to the lack of sharing of stacklots:
prev parent reply other threads:[~2006-01-12 23:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-09 21:11 [GIT PATCHES] kbuild updates Sam Ravnborg
2006-01-09 21:38 ` [PATCH 01/11] kconfig: factor out ncurses check in a shell script Sam Ravnborg
2006-01-10 20:27 ` Jan Engelhardt
2006-01-10 21:01 ` Sam Ravnborg
2006-01-10 21:28 ` Jan Engelhardt
2006-01-11 16:55 ` Sam Ravnborg
2006-01-11 18:11 ` Jan Engelhardt
2006-01-09 21:38 ` [PATCH 02/11] kbuild: clean up asm-offsets.h creation Sam Ravnborg
2006-01-09 21:38 ` [PATCH 03/11] modpost/file2alias: Fix typo Sam Ravnborg
2006-01-09 21:38 ` [PATCH 04/11] kbuild: In setlocalversion change -git_dirty to just -dirty Sam Ravnborg
2006-01-09 21:38 ` [PATCH 05/11] kbuild: ensure mrproper removes .old_version Sam Ravnborg
2006-01-09 21:38 ` [PATCH 06/11] kbuild: reference_discarded addition Sam Ravnborg
2006-01-09 21:38 ` [PATCH 07/11] kbuild: remove GCC_VERSION Sam Ravnborg
2006-01-09 21:38 ` [PATCH 08/11] frv: Use KERNELRELEASE Sam Ravnborg
2006-01-09 21:38 ` [PATCH 09/11] kbuild: drop vmlinux dependency from "make install" Sam Ravnborg
2006-01-12 16:21 ` Cal Peake
2006-01-12 21:25 ` Sam Ravnborg
2006-01-31 20:11 ` Dave Hansen
2006-01-31 21:04 ` [PATCH 09/11] kbuild: drop vmlinux dependency from 'make install' Sam Ravnborg
2006-02-01 23:27 ` Keith Owens
2006-01-09 21:38 ` [PATCH 10/11] kbuild/xfs: introduce fs/xfs/Kbuild Sam Ravnborg
2006-01-09 21:38 ` [PATCH 11/11] kbuild: KERNELRELEASE is only re-defined when buiding the kernel Sam Ravnborg
2006-01-09 21:50 ` [PATCH 12/11] kbuild: re-export VERSION, PATCHLEVEL, SUBLEVEL Sam Ravnborg
2006-01-10 16:27 ` [GIT PATCHES] kbuild updates Linus Torvalds
2006-01-12 23:18 ` Adrian Bunk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060112231833.GC29663@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.