From: Evgeniy <dushistov@mail.ru>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: [PATCH 2.6.15] Re: Oops in ufs_fill_super at mount time
Date: Fri, 13 Jan 2006 18:12:15 +0300 [thread overview]
Message-ID: <20060113151215.GA25854@rain.homenetwork> (raw)
In-Reply-To: <20060113005450.GA7971@mipter.zuzino.mipt.ru>
On Fri, Jan 13, 2006 at 03:54:50AM +0300, Alexey Dobriyan wrote:
> Version 2.6.15-43ecb9a33ba8c93ebbda81d48ca05f0d1bbf9056
>
> Actually more or less latest -git is affected too, but
> I'm sick of recompiling right now so please wait for bisecting results.
>
> It's random wrt one mount of UFS, but several mount/umounts in a row
> reproduce it reliably:
>
I suppose problem in a couple of brackets in fs/ufs/utils.h,
instead of 512th byte of buffer, usb2 point to nth structure of
type ufs_super_block_second.
This patch fix problem for me,
can you test it?
Signed-off-by: Evgeniy Dushistov <dushistov@mail.ru>
---
--- linux-2.6.15/fs/ufs/util.h.orig 2006-01-13 17:33:49.123946250 +0300
+++ linux-2.6.15/fs/ufs/util.h 2006-01-13 17:35:50.127508500 +0300
@@ -255,8 +255,8 @@ extern void _ubh_memcpyubh_(struct ufs_s
((struct ufs_super_block_first *)((ubh)->bh[0]->b_data))
#define ubh_get_usb_second(ubh) \
- ((struct ufs_super_block_second *)(ubh)-> \
- bh[UFS_SECTOR_SIZE >> uspi->s_fshift]->b_data + (UFS_SECTOR_SIZE & ~uspi->s_fmask))
+ ((struct ufs_super_block_second *)((ubh)->\
+ bh[UFS_SECTOR_SIZE >> uspi->s_fshift]->b_data + (UFS_SECTOR_SIZE & ~uspi->s_fmask)))
#define ubh_get_usb_third(ubh) \
((struct ufs_super_block_third *)((ubh)-> \
--
/Evgeniy
prev parent reply other threads:[~2006-01-13 15:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-13 0:54 Oops in ufs_fill_super at mount time Alexey Dobriyan
2006-01-13 1:14 ` Linus Torvalds
2006-01-13 10:21 ` Alexey Dobriyan
2006-01-13 15:45 ` Linus Torvalds
2006-01-13 16:36 ` Alexey Dobriyan
2006-01-13 19:05 ` [PATCH 2.6.15] ufs cleanup Evgeniy
2006-01-13 19:51 ` Linus Torvalds
2006-01-14 8:42 ` [PATCH 2.6.15] ufs cleanup v. 2 Evgeniy
2006-01-13 15:12 ` Evgeniy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060113151215.GA25854@rain.homenetwork \
--to=dushistov@mail.ru \
--cc=adobriyan@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.