From: Con Kolivas <kernel@kolivas.org>
To: Mike Galbraith <efault@gmx.de>
Cc: linux kernel mailing list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@elte.hu>
Subject: [PATCH] sched - fix interactive typo
Date: Sun, 15 Jan 2006 01:36:35 +1100 [thread overview]
Message-ID: <200601150136.38176.kernel@kolivas.org> (raw)
In-Reply-To: <5.2.1.1.2.20060114134639.00c453d0@pop.gmx.net>
[-- Attachment #1: Type: text/plain, Size: 2201 bytes --]
On Saturday 14 January 2006 23:56, Mike Galbraith wrote:
> Greetings,
>
> At 09:23 PM 1/13/2006 +1100, Con Kolivas wrote:
> >Index: linux-2.6.15/kernel/sched.c
> >===================================================================
> >--- linux-2.6.15.orig/kernel/sched.c
> >+++ linux-2.6.15/kernel/sched.c
> >@@ -756,26 +756,17 @@ static int recalc_task_prio(task_t *p, u
>
> <snip>
>
> >+ * If a task was sleeping with the noninteractive
> >+ * label do not apply this non-linear boost
> > */
> >- if (p->sleep_type == SLEEP_NONINTERACTIVE &&
> > p->mm) { - if (p->sleep_avg >=
> > INTERACTIVE_SLEEP(p)) - sleep_time
> > = 0;
> >- else if (p->sleep_avg + sleep_time >=
> >- INTERACTIVE_SLEEP(p)) {
> >- p->sleep_avg =
> > INTERACTIVE_SLEEP(p); - sleep_time
> > = 0;
> >- }
> >- }
> >+ if (p->sleep_type != SLEEP_NONINTERACTIVE ||
> > p->mm)
>
> Typo alert. Looks like that should be ||
> !p->mm. ^
Good catch!
That would have hurt like that too.
Andrew please apply to or rollup into interactivity series.
Cheers,
Con
---
Fix typo thanks Mike Galbraith for spotting.
Signed-off-by: Con Kolivas <kernel@kolivas.org>
kernel/sched.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.15/kernel/sched.c
===================================================================
--- linux-2.6.15.orig/kernel/sched.c
+++ linux-2.6.15/kernel/sched.c
@@ -768,7 +768,7 @@ static int recalc_task_prio(task_t *p, u
* If a task was sleeping with the noninteractive
* label do not apply this non-linear boost
*/
- if (p->sleep_type != SLEEP_NONINTERACTIVE || p->mm)
+ if (p->sleep_type != SLEEP_NONINTERACTIVE || !p->mm)
sleep_time *=
(MAX_BONUS - CURRENT_BONUS(p)) ? : 1;
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2006-01-14 14:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-13 10:23 [PATCH 2/5] sched-alter_uninterruptible_sleep_interactivity.patch Con Kolivas
2006-01-14 12:56 ` Mike Galbraith
2006-01-14 14:36 ` Con Kolivas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200601150136.38176.kernel@kolivas.org \
--to=kernel@kolivas.org \
--cc=akpm@osdl.org \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.