From: "René Rebe" <rene@exactcode.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@osdl.org>,
Roman Zippel <zippel@linux-m68k.org>,
akpm@osdl.org
Subject: Re: kbuild / KERNELRELEASE not rebuild correctly anymore
Date: Sun, 15 Jan 2006 13:12:42 +0100 [thread overview]
Message-ID: <200601151312.42391.rene@exactcode.de> (raw)
In-Reply-To: <20060115111922.GA13673@mars.ravnborg.org>
Hi,
On Sunday 15 January 2006 12:19, Sam Ravnborg wrote:
> On Sun, Jan 15, 2006 at 11:41:30AM +0100, Ren? Rebe wrote:
> > > So the real fix is to error out when .kernelrelease does not exists.
> > > See attached patch.
> >
> > You expect us to run make prepare before make menuconfig or simillar?
> > That sounds a bit odd ...
>
> The kernelrelease depends on the actual configuration.
> So without having completed the make *config step kbuild cannot tell the
> correct kernelrelease.
>
> Now with the patch attached to last mail kbuild will now error out in
> case there is no valid kernelrelease. Thats obviously only a hack, since
> we need to error out when .config has been updated and the new
> kernelrelease has not been created.
>
> Maybe the better approach would be always to create the .kernelrelease
> file as part of the configuration - based on the principle of least
> suprise.
Aside this "solution" still annoys me, you need at least patch the config
stuff to not display an empty version string ;-)
I'm curious, aside rsbac, what in the .config is altering the KERNELRELEASE?
Yours,
--
René Rebe - Rubensstr. 64 - 12157 Berlin (Europe / Germany)
http://www.exactcode.de | http://www.t2-project.org
+49 (0)30 255 897 45
next prev parent reply other threads:[~2006-01-15 12:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-15 9:51 kbuild / KERNELRELEASE not rebuild correctly anymore René Rebe
2006-01-15 10:05 ` Sam Ravnborg
2006-01-15 10:41 ` René Rebe
2006-01-15 11:19 ` Sam Ravnborg
2006-01-15 12:12 ` René Rebe [this message]
2006-01-15 12:31 ` Sam Ravnborg
2006-01-15 14:26 ` René Rebe
2006-01-15 23:29 ` Kyle Moffett
2006-01-16 11:15 ` [PATCH] kbuild: create .kernelrelease at *config step Sam Ravnborg
2006-01-15 10:13 ` kbuild / KERNELRELEASE not rebuild correctly anymore Grant Coady
2006-01-15 10:42 ` René Rebe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200601151312.42391.rene@exactcode.de \
--to=rene@exactcode.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=torvalds@osdl.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.