All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Toshihiro.Kobayashi@nokia.com
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] Replace clk_use/unuse with clk_enable/disable, please test
Date: Mon, 16 Jan 2006 10:52:40 -0800	[thread overview]
Message-ID: <20060116185239.GJ4511@atomide.com> (raw)
In-Reply-To: <7AF192DA69C59243838FF62851F64F5501B00F46@toebe101.NOE.Nokia.com>

* Toshihiro.Kobayashi@nokia.com <Toshihiro.Kobayashi@nokia.com> [060116 02:16]:
> Hi,
> 
> Here's a further patch to centralize the pm code. (patch-dsp_ckfix3)

Thanks, pushing today.
 
> >From: ext Tony Lindgren [mailto:tony@atomide.com] 
> >Sent: Saturday, January 14, 2006 10:13 AM
> 
> >Thanks for deciphering it :) I wonder if we could just take care of the
> >temporary enable in the clock framework?
> 
> I tried, please look at the one more patch.
> (patch-clk_enable_force-test)
> But I myself don't agree with this patch ;-(

OK
 
> I feel it's too arbitrate to add clk_enable_force() and
> clk_disable_force() to the clk_functions struct, only for the
> pm code. And I think it's OK to do raw register accesses within
> the pm code, including clock enableing / disabling, since anyway
> the assembler part (omapXXXX_idle_loop_suspend) does such
> operations.

Yeah, some direct register access is needed in PM code...

Tony

      reply	other threads:[~2006-01-16 18:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-05 23:20 [PATCH] Replace clk_use/unuse with clk_enable/disable, please test Tony Lindgren
2006-01-06 13:08 ` Komal Shah
2006-01-12 22:54   ` Tony Lindgren
2006-01-06 13:09 ` Komal Shah
2006-01-13 12:10 ` Toshihiro.Kobayashi
2006-01-13 12:27   ` Toshihiro.Kobayashi
2006-01-14  1:12     ` Tony Lindgren
2006-01-16 10:15       ` Toshihiro.Kobayashi
2006-01-16 18:52         ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060116185239.GJ4511@atomide.com \
    --to=tony@atomide.com \
    --cc=Toshihiro.Kobayashi@nokia.com \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.