From: "David S. Miller" <davem@davemloft.net>
To: stern@rowland.harvard.edu
Cc: bcrl@kvack.org, akpm@osdl.org, sekharan@us.ibm.com, kaos@sgi.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/8] Notifier chain update
Date: Wed, 18 Jan 2006 14:00:56 -0800 (PST) [thread overview]
Message-ID: <20060118.140056.39962680.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0601181656430.4974-100000@iolanthe.rowland.org>
From: Alan Stern <stern@rowland.harvard.edu>
Date: Wed, 18 Jan 2006 16:57:30 -0500 (EST)
> On Wed, 18 Jan 2006, Benjamin LaHaise wrote:
>
> > A notifier callee should not be sleeping, if anything it should be putting
> > its work onto a workqueue and completing it when it gets scheduled if it
> > has to do something that blocks.
>
> Sez who? If it's not documented in the kernel source, I don't believe
> it.
Many notifiers even get run from software interrupt context,
making sleeping illegal.
For example, IPV6 addresses can get added/removed from a device
in response to packets, and these operations trigger the
inet6addr_chain notifier in net/ipv6/addrconf.c
So sleeping in a notifier is indeed illegal.
next prev parent reply other threads:[~2006-01-18 22:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-18 16:34 [PATCH 1/8] Notifier chain update Alan Stern
2006-01-18 18:19 ` Benjamin LaHaise
2006-01-18 20:23 ` Alan Stern
2006-01-18 21:42 ` Benjamin LaHaise
2006-01-18 21:57 ` Alan Stern
2006-01-18 22:00 ` David S. Miller [this message]
2006-01-18 22:04 ` Alan Stern
2006-01-18 23:06 ` Alan Cox
2006-01-19 3:33 ` Alan Stern
2006-01-18 22:01 ` Benjamin LaHaise
2006-01-18 22:09 ` Alan Stern
2006-01-18 22:15 ` Benjamin LaHaise
2006-01-19 10:01 ` Jes Sorensen
2006-01-18 22:18 ` David S. Miller
2006-01-18 22:18 ` Benjamin LaHaise
2006-01-18 23:07 ` Alan Cox
2006-01-19 9:55 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060118.140056.39962680.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=bcrl@kvack.org \
--cc=kaos@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sekharan@us.ibm.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.