Re: Cold plug starting services too soon

[Roy Marples <uberlord@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1974 bytes --]

On Wednesday 18 January 2006 00:27, Greg KH wrote:
> On Tue, Jan 17, 2006 at 09:43:03PM +0100, Kay Sievers wrote:
> > All running events are exported in /dev/.udev/queue/, events that fail
> > will be moved to /dev/.udev/failed/. Make sure the script return non-zero
> > if it can't run and retry all failed events from /dev/.udev/failed/
> > after "localfs" is done. If the same event then runs successfully, it
> > will go away from /dev/.udev/failed/. On SUSE I have a second udev boot
> > script that is called /etc/init.d/boot.udev_retry.
>
> Cool, I'll try doing that for Gentoo and see how it works out.  Thanks
> for adding this to udev already.
>
> Roy, do you think this will work out properly?

Yes, this can work out nicely. However, I don't see /dev/.udev/failed when we 
exit with code 1. Is there something I'm missing?

Currently I have this fairly near the top of runscript.sh

# Ensure that we have completed sysinit
if [[ ${IN_HOTPLUG} == 1 ]] ; then
    for pid in $(pidof bash) ; do
        if [[ "$(cat "/proc/${pid}/cmdline" 2>/dev/null)" \
            == "/bin/bash/sbin/rcsysinit" ]] ; then
            eerror "ERROR:  cannot hotplug ${myservice} until sysinit has 
run."
            exit 1
        fi
    done
    unset pid
fi

Now thats very hacky, but the only way I can think of to find out if our rc 
system has completed its sysinit. A better solution would be this

# Ensure that we have completed sysinit
if [[ ${RC_SYSINIT} == 1 ]] ; then
   eerror "ERROR:  cannot run ${myservice} until sysinit has completed."
   exit 1
fi

Obviously this only works if rc can configure udev to export shell variables 
before triggerring hotplugable events and can change/unset/add it after 
sysinit. Something like this maybe.

udev_set_env "RC_SYSINIT=1"

do stuff to complete sysinit

udev_sev_env "RC_SYSINIT="

Can we do this Greg?

-- 
Roy Marples <uberlord@gentoo.org>
Gentoo Linux Developer

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]