From: "Juha Yrjölä" <juha.yrjola@nokia.com>
To: ext Komal Shah <komal_shah802003@yahoo.com>
Cc: linux-omap-open-source@linux.omap.com, Mikko.Soikkala@tietoenator.com
Subject: Re: [PATCH] Convert touchscreen to input_allocate_device
Date: Wed, 18 Jan 2006 13:21:55 +0200 [thread overview]
Message-ID: <20060118112155.GA16067@two.research.nokia.com> (raw)
In-Reply-To: <20060118101057.83839.qmail@web32903.mail.mud.yahoo.com>
On Wed, Jan 18, 2006 at 02:10:57AM -0800, ext Komal Shah wrote:
> > How about if we move the allocation and check to the beginning of the
> > probe function? Then the return shouldn't cause problems?
>
> Ok. Looks good now.
Not quite yet. =) If you allocate the input device earlier, you also have to
take care in deallocating it in the error paths after it.
Cheers,
Juha
next prev parent reply other threads:[~2006-01-18 11:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-18 9:34 [PATCH] Convert touchscreen to input_allocate_device Mikko.Soikkala
2006-01-18 10:10 ` Komal Shah
2006-01-18 11:21 ` Juha Yrjölä [this message]
2006-01-18 16:39 ` Komal Shah
2006-01-20 23:07 ` Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2006-01-17 13:24 Mikko.Soikkala
2006-01-17 15:12 ` Komal Shah
2006-01-16 11:59 Mikko.Soikkala
2006-01-16 18:15 ` Dirk Behme
2005-12-27 9:51 Pending patches Dirk Behme
2005-12-30 22:28 ` Tony Lindgren
2006-01-03 19:13 ` Pending patches mostly pushed, please check Tony Lindgren
2006-01-06 19:37 ` [PATCH] Convert touchscreen to input_allocate_device Dirk Behme
2006-01-14 0:18 ` Tony Lindgren
2005-12-04 15:52 Dirk Behme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060118112155.GA16067@two.research.nokia.com \
--to=juha.yrjola@nokia.com \
--cc=Mikko.Soikkala@tietoenator.com \
--cc=komal_shah802003@yahoo.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.