From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1Ezesy-0005CM-0A for user-mode-linux-devel@lists.sourceforge.net; Thu, 19 Jan 2006 10:51:52 -0800 Received: from saraswathi.solana.com ([198.99.130.12]) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1Ezesw-0002Mi-0z for user-mode-linux-devel@lists.sourceforge.net; Thu, 19 Jan 2006 10:51:52 -0800 From: Jeff Dike Subject: Re: [uml-devel] [PATCH 8/8] uml: avoid "CONFIG_NR_CPUS undeclared" bogus error messages Message-ID: <20060119194356.GA8670@ccure.user-mode-linux.org> References: <20060118235132.4626.74049.stgit@zion.home.lan> <20060118235522.4626.2825.stgit@zion.home.lan> <20060119042104.GC8265@ccure.user-mode-linux.org> <200601191601.31805.blaisorblade@yahoo.it> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200601191601.31805.blaisorblade@yahoo.it> Sender: user-mode-linux-devel-admin@lists.sourceforge.net Errors-To: user-mode-linux-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: The user-mode Linux development list List-Post: List-Help: List-Subscribe: , List-Archive: Date: Thu, 19 Jan 2006 14:43:56 -0500 To: Blaisorblade Cc: linux-kernel@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net On Thu, Jan 19, 2006 at 04:01:28PM +0100, Blaisorblade wrote: > Gerd Knorr in his tty patch, instead, used forward declarations, like: > > struct task_struct; > > what about that? I don't think so. At least when you use void *, you are using a type that's not incorrect. In userspace code, those task_structs start referring to host task_structs, which is definitely very wrong. > Those functions probably should be moved anyway because they're > useless there Yeah. Jeff ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642 _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161210AbWASSwE (ORCPT ); Thu, 19 Jan 2006 13:52:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161220AbWASSwE (ORCPT ); Thu, 19 Jan 2006 13:52:04 -0500 Received: from saraswathi.solana.com ([198.99.130.12]:24529 "EHLO saraswathi.solana.com") by vger.kernel.org with ESMTP id S1161243AbWASSwB (ORCPT ); Thu, 19 Jan 2006 13:52:01 -0500 Date: Thu, 19 Jan 2006 14:43:56 -0500 From: Jeff Dike To: Blaisorblade Cc: linux-kernel@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net Subject: Re: [uml-devel] [PATCH 8/8] uml: avoid "CONFIG_NR_CPUS undeclared" bogus error messages Message-ID: <20060119194356.GA8670@ccure.user-mode-linux.org> References: <20060118235132.4626.74049.stgit@zion.home.lan> <20060118235522.4626.2825.stgit@zion.home.lan> <20060119042104.GC8265@ccure.user-mode-linux.org> <200601191601.31805.blaisorblade@yahoo.it> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200601191601.31805.blaisorblade@yahoo.it> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 19, 2006 at 04:01:28PM +0100, Blaisorblade wrote: > Gerd Knorr in his tty patch, instead, used forward declarations, like: > > struct task_struct; > > what about that? I don't think so. At least when you use void *, you are using a type that's not incorrect. In userspace code, those task_structs start referring to host task_structs, which is definitely very wrong. > Those functions probably should be moved anyway because they're > useless there Yeah. Jeff