All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: lamikr <lamikr@cc.jyu.fi>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: omap1510/16xx fixes for the tsc2101 oss driver
Date: Thu, 19 Jan 2006 12:04:23 -0800	[thread overview]
Message-ID: <20060119200423.GL4425@atomide.com> (raw)
In-Reply-To: <43CB0447.2000606@cc.jyu.fi>

* lamikr <lamikr@cc.jyu.fi> [060115 18:26]:
> 1) mcbsp.h needs to define AUDIO_MCBSP_DATAREAD and
> AUDIO_MCBSP_DATAWRITE functions, etc... both for the omap1510 and
> omap16xx oterwise the sound/oss/omap-audio-dma-intfc.c fails to compile
> with omap1.
> 
> 2) Added cpu_is_omap1510 check to places which earlier only checked
> cpu_is_omap16xx() so that the dma got initialized properly also with the
> omap1510 based iPAQ h6300.
> 
> 3)  DCSR_ERROR check looked suspicious compared to the version in 2.6.14
> kernel. In addition that prevented the sound working after first played
> frame
> in the iPAQ h6300 as assumed always that error had happened.
> 
> After applying attached fixes, cat my_song.wav > /dev/dsp worked ok for me.

Thanks, I'll push this today at some point.

Tony

      reply	other threads:[~2006-01-19 20:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-16  2:26 omap1510/16xx fixes for the tsc2101 oss driver lamikr
2006-01-19 20:04 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060119200423.GL4425@atomide.com \
    --to=tony@atomide.com \
    --cc=lamikr@cc.jyu.fi \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.