All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] Fix AUDIO_MCBSP_DATAREAD/WRITE undefined for OMAP16xx
Date: Thu, 19 Jan 2006 12:05:05 -0800	[thread overview]
Message-ID: <20060119200505.GM4425@atomide.com> (raw)
In-Reply-To: <43CD43B9.70902@cc.jyu.fi>

* lamikr <lamikr@cc.jyu.fi> [060117 13:47]:
> For this I think it would be better to take the patch from the message
> titled "omap1510/16xx fixes for the tsc2101 oss driver" I send yesterday.
> It defines the AUDIO_MCBSP_DATAWRITE and AUDIO_MCBSP_DATAREAD for the
> omap1510/16xx in a similar way than is done for the omap24xx.
> 
> Mika
> 
> Dirk Behme wrote:
> 
> >
> > ARM: OMAP: Define AUDIO_MCBSP_DATAREAD/WRITE for OMAP16xx as well
> >
> > Fix error
> >
> > sound/oss/omap-audio-dma-intfc.c:715: error: `AUDIO_MCBSP_DATAWRITE'
> > undeclared (first use in this function)
> > sound/oss/omap-audio-dma-intfc.c:745: error: `AUDIO_MCBSP_DATAREAD'
> > undeclared (first use in this function)
> >
> > Signed-off-by: Dirk Behme <dirk.behme_at_de.bosch.com>
> >
> >------------------------------------------------------------------------
> >
> >--- ./include/asm-arm/arch-omap/mcbsp.h_orig	2006-01-17 18:34:46.000000000 +0100
> >+++ ./include/asm-arm/arch-omap/mcbsp.h	2006-01-17 18:37:11.720163080 +0100
> >@@ -80,6 +80,9 @@
> > #define AUDIO_DMA_TX		OMAP_DMA_MCBSP1_TX
> > #define AUDIO_DMA_RX		OMAP_DMA_MCBSP1_RX
> > 
> >+#define AUDIO_MCBSP_DATAWRITE	(0)
> >+#define AUDIO_MCBSP_DATAREAD	(0)
> >+
> > #elif defined(CONFIG_ARCH_OMAP24XX)
> > 
> > #define OMAP_MCBSP_REG_DRR2	0x00

I'll push Mika's patch at some point today as it also include this one.

Tony

      reply	other threads:[~2006-01-19 20:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-17 18:44 [PATCH] Fix AUDIO_MCBSP_DATAREAD/WRITE undefined for OMAP16xx Dirk Behme
2006-01-17 19:21 ` lamikr
2006-01-19 20:05   ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060119200505.GM4425@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.