From: Greg KH <gregkh@suse.de>
To: "V. Ananda Krishnan" <mansarov@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk,
rmk@arm.linux.org.uk, akpm@osdl.org
Subject: Re: [PATCH]-jsm driver fix for linux-2.6.16-rc1
Date: Fri, 20 Jan 2006 08:10:44 -0800 [thread overview]
Message-ID: <20060120161044.GA26249@suse.de> (raw)
In-Reply-To: <43D1099E.3050509@us.ibm.com>
On Fri, Jan 20, 2006 at 10:02:38AM -0600, V. Ananda Krishnan wrote:
> @@ -20,8 +20,11 @@
> *
> * Contact Information:
> * Scott H Kilau <Scott_Kilau@digi.com>
> - * Wendy Xiong <wendyx@us.ltcfwd.linux.ibm.com>
> - *
> + * Wendy Xiong <wendyx>
That's not an email address, why not just fix Wendy's to be correct, or
drop it if that's not the person to contact?
> + /*
> + * If the DONT_FLIP flag is on, don't flush our buffer, and act
Wrong code indentation, use tabs please. This is in a number of places
in the patch.
thanks,
greg k-h
next prev parent reply other threads:[~2006-01-20 16:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-20 16:02 [PATCH]-jsm driver fix for linux-2.6.16-rc1 V. Ananda Krishnan
2006-01-20 16:10 ` Greg KH [this message]
2006-01-20 18:23 ` Alan Cox
2006-01-23 18:27 ` V. Ananda Krishnan
2006-01-23 18:46 ` Greg KH
2006-01-23 21:19 ` V. Ananda Krishnan
2006-01-23 21:42 ` Greg KH
2006-01-24 22:28 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060120161044.GA26249@suse.de \
--to=gregkh@suse.de \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mansarov@us.ibm.com \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.