From: Ashok Raj <ashok.raj@intel.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@osdl.org, ak@muc.de, matthew.e.tolentino@intel.com
Subject: __cpuinit functions wrongly marked __meminit
Date: Fri, 20 Jan 2006 17:37:23 -0800 [thread overview]
Message-ID: <20060120173723.A7060@unix-os.sc.intel.com> (raw)
Hi Andrew
This is required, __meminit has overzelously been modified and crept its way
into marking cpuup callbacks as __meminit.
I still have some trouble in getting cpu up to work on x86_64, even with these
changes and it might be some other changes that iam trying to hunt down.
Seems NUMA related. IA64 seems to work fine for now.
--
Cheers,
Ashok Raj
- Open Source Technology Center
__meminit has overzelously been modified and crept its way
into marking cpuup callbacks as __meminit.
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
------------------------------------------------
mm/page_alloc.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
Index: linux-2.6.16-rc1-mm2/mm/page_alloc.c
===================================================================
--- linux-2.6.16-rc1-mm2.orig/mm/page_alloc.c
+++ linux-2.6.16-rc1-mm2/mm/page_alloc.c
@@ -1876,7 +1876,7 @@ void zonetable_add(struct zone *zone, in
memmap_init_zone((size), (nid), (zone), (start_pfn))
#endif
-static int __meminit zone_batchsize(struct zone *zone)
+static int __cpuinit zone_batchsize(struct zone *zone)
{
int batch;
@@ -1970,7 +1970,7 @@ static struct per_cpu_pageset
* Dynamically allocate memory for the
* per cpu pageset array in struct zone.
*/
-static int __meminit process_zones(int cpu)
+static int __cpuinit process_zones(int cpu)
{
struct zone *zone, *dzone;
@@ -2011,7 +2011,7 @@ static inline void free_zone_pagesets(in
}
}
-static int __meminit pageset_cpuup_callback(struct notifier_block *nfb,
+static int __cpuinit pageset_cpuup_callback(struct notifier_block *nfb,
unsigned long action,
void *hcpu)
{
next reply other threads:[~2006-01-21 1:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-21 1:37 Ashok Raj [this message]
2006-01-21 2:00 ` __cpuinit functions wrongly marked __meminit Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2006-01-21 16:45 Tolentino, Matthew E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060120173723.A7060@unix-os.sc.intel.com \
--to=ashok.raj@intel.com \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.e.tolentino@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.