From: Jens Axboe <axboe@suse.de>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] BLOCK: use disk_stat_add instead of __disk_stat_add in __end_that_request_first
Date: Sat, 21 Jan 2006 20:46:34 +0100 [thread overview]
Message-ID: <20060121194632.GU13429@suse.de> (raw)
In-Reply-To: <20060121172233.GA18239@htj.dyndns.org>
On Sun, Jan 22 2006, Tejun Heo wrote:
> Unlike end_that_request_last, caller is supposed to own the request
> when it calls __end_that_request_first and thus allowed to call from
> any context without any locking. When SCSI EH completes requests, it
> calls __end_that_request_first from kernel thread context without
> holding any lock and none of preemption/bh/irq disabled. This results
> in the following warning.
>
> BUG: using smp_processor_id() in preemptible [00000001] code: scsi_eh_6/927
> caller is __end_that_request_first+0xbf/0x500
> [<c01046e3>] show_trace+0x13/0x20
> [<c010470e>] dump_stack+0x1e/0x20
> [<c02231c8>] debug_smp_processor_id+0xa8/0xb0
> [<c021167f>] __end_that_request_first+0xbf/0x500
> [<c0211ad1>] end_that_request_chunk+0x11/0x20
> [<c03360b2>] scsi_end_request+0x32/0x110
> -- snip --
>
> This patch makes __end_that_request_first() use undashed
> disk_stat_add() which doesn't assume preemption is disabled.
Patch is good, however I already added this identical patch to the block
git repo last week :-)
--
Jens Axboe
prev parent reply other threads:[~2006-01-21 19:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-21 17:22 [PATCH] BLOCK: use disk_stat_add instead of __disk_stat_add in __end_that_request_first Tejun Heo
2006-01-21 19:46 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060121194632.GU13429@suse.de \
--to=axboe@suse.de \
--cc=htejun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.