From: Andrew Morton <akpm@osdl.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: rmk+serial@arm.linux.org.uk, linux-kernel@vger.kernel.org,
ralf@linux-mips.org
Subject: Re: [PATCH] serial: serial_txx9 driver update
Date: Sat, 21 Jan 2006 23:36:49 -0800 [thread overview]
Message-ID: <20060121233649.51211403.akpm@osdl.org> (raw)
In-Reply-To: <20060118.021901.71085469.anemo@mba.ocn.ne.jp>
Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
>
> serial_txx9_verify_port(struct uart_port *port, struct serial_struct *ser)
> {
> - if (ser->irq < 0 ||
> - ser->baud_base < 9600 || ser->type != PORT_TXX9)
> + unsigned long new_port = (unsigned long)ser->port +
> + ((unsigned long)ser->port_high << ((sizeof(long) - sizeof(int)) * 8));
Are you sure about this part? Shifting something left by sizeof(something)
seems very strange. It'll give different results on 64-bit machines for
the same hardware. Are you sure it wasn't supposed to be an addition?
If this was indeed intended then can you please explain why?
If it was supposed to be an addition, wouldn't this be more clearly
expressed by defining a suitable structure and using sizeof(that structure)
to work out the address range?
next prev parent reply other threads:[~2006-01-22 7:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-17 17:19 [PATCH] serial: serial_txx9 driver update Atsushi Nemoto
2006-01-22 7:36 ` Andrew Morton [this message]
2006-01-22 8:00 ` Russell King
2006-01-22 8:33 ` Andrew Morton
2006-01-22 23:02 ` Russell King
2006-01-23 6:05 ` Atsushi Nemoto
2006-01-23 9:57 ` Russell King
2006-01-23 13:39 ` Atsushi Nemoto
2006-01-23 13:42 ` Atsushi Nemoto
2006-01-23 19:49 ` Russell King
2006-01-24 2:24 ` Atsushi Nemoto
-- strict thread matches above, loose matches on Subject: below --
2006-12-21 17:01 Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060121233649.51211403.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=rmk+serial@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.