From: Dmitry Torokhov <dtor_core@ameritech.net>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Marek Va?ut <marek.vasut@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: Guillemot joystick not working since 2.6.14
Date: Mon, 23 Jan 2006 00:48:42 -0500 [thread overview]
Message-ID: <200601230048.43360.dtor_core@ameritech.net> (raw)
In-Reply-To: <20060122195550.GA19983@mipter.zuzino.mipt.ru>
On Sunday 22 January 2006 14:55, Alexey Dobriyan wrote:
> On Sun, Jan 22, 2006 at 12:50:26PM +0100, Marek Va?ut wrote:
> > I found a problem with guillemot "force feedback joystick". It?s not working
> > since 2.6.13.2-mm3. 2.6.14.2 wasn?t working too. 2.6.15-mm2 is the same. When
> > I plug it in, it prints "configuration #1 chosen from 1 choice" "registered
> > new driver iforce" and >"iforce: probe of 4-2:1.0 failed with error -12"<
> > It was working well on 2.6.13.1, but now it doesnt. I am not able to debug the
> > kernel. Could you please fix this or tell me what am I doing wrong? Thanks.
>
> Please try this patch
>
> --- a/drivers/input/joystick/iforce/iforce-main.c
> +++ b/drivers/input/joystick/iforce/iforce-main.c
> @@ -345,7 +345,7 @@ int iforce_init_device(struct iforce *if
> int i;
>
> input_dev = input_allocate_device();
> - if (input_dev)
> + if (!input_dev)
> return -ENOMEM;
>
> init_waitqueue_head(&iforce->wait);
>
Doh! Could you please add your signoff so I'd add it to the input tree?
Anyway, dynalloc went in 2.6.15 so something else is amiss...
--
Dmitry
next prev parent reply other threads:[~2006-01-23 5:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-22 11:50 Guillemot joystick not working since 2.6.14 Marek Vašut
2006-01-22 19:55 ` Alexey Dobriyan
2006-01-23 5:48 ` Dmitry Torokhov [this message]
2006-01-23 15:28 ` [PATCH] iforce: fix -ENOMEM check Alexey Dobriyan
2006-01-25 5:51 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200601230048.43360.dtor_core@ameritech.net \
--to=dtor_core@ameritech.net \
--cc=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.vasut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.