From: Andrew Morton <akpm@osdl.org>
To: Fernando Luis Vazquez Cao <fernando@intellilink.co.jp>
Cc: ebiederm@xmission.com, ak@suse.de, vgoyal@in.ibm.com,
linux-kernel@vger.kernel.org, fastboot@lists.osdl.org
Subject: Re: [PATCH 3/5] stack overflow safe kdump (2.6.16-rc1-i386) - fault
Date: Tue, 24 Jan 2006 23:15:10 -0800 [thread overview]
Message-ID: <20060124231510.35eabe15.akpm@osdl.org> (raw)
In-Reply-To: <1138172000.2370.68.camel@localhost.localdomain>
Fernando Luis Vazquez Cao <fernando@intellilink.co.jp> wrote:
>
> When we have a bloated stack it is likely that it ends up making an
> invalid memory access that in turn causes a page fault. Take this case
> into account in the page fault code.
>
> + if (!virt_addr_valid(tsk)) {
Is virt_addr_valid() a sufficiently strong test here? One could probe the
address to see if it generates a fault, like the __get_user() in
kmem_cache_create().
> + printk("do_page_fault: Discarding invalid 'current' struct task_struct * = 0x%p\n", tsk);
> + printk("do_page_fault: Discarding invalid current->mm struct mm_struct * = 0x%p\n", mm);
Try to make the code look nice in an 80-col window please.
next prev parent reply other threads:[~2006-01-25 7:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-25 6:53 [PATCH 3/5] stack overflow safe kdump (2.6.16-rc1-i386) - fault Fernando Luis Vazquez Cao
2006-01-25 7:15 ` Andrew Morton [this message]
2006-01-25 7:56 ` Andi Kleen
2006-01-25 8:00 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060124231510.35eabe15.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ak@suse.de \
--cc=ebiederm@xmission.com \
--cc=fastboot@lists.osdl.org \
--cc=fernando@intellilink.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.