From: Jens Axboe <axboe@suse.de>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Borislav Petkov <bbpetkov@yahoo.de>,
linux-ide@vger.kernel.org, htejun@gmail.com,
randy_d_dunlap@linux.intel.com
Subject: Re: PATCH convert libata-core to the new debugging scheme
Date: Wed, 25 Jan 2006 16:16:48 +0100 [thread overview]
Message-ID: <20060125151645.GF4212@suse.de> (raw)
In-Reply-To: <20060125151250.GD14225@havoc.gtf.org>
On Wed, Jan 25 2006, Jeff Garzik wrote:
> On Wed, Jan 25, 2006 at 04:13:44PM +0100, Jens Axboe wrote:
> > It looks cleaner, though. printk() lines are usually the worst to keep
> > from wrapping, saving a tab indentation there seems like it would be
> > worth it imho.
>
> We have an explosion of printk() macros in the kernel already, and
> hiding the 'if' test has little value to me...
Well that's mainly because every driver / sub-system roll their own
debug-printk system. It's not about hiding the if test imo, it's about
saving the identation.
--
Jens Axboe
next prev parent reply other threads:[~2006-01-25 15:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-24 19:43 PATCH convert libata-core to the new debugging scheme Borislav Petkov
2006-01-24 19:47 ` Jeff Garzik
2006-01-25 15:04 ` Bartlomiej Zolnierkiewicz
2006-01-25 15:06 ` Jeff Garzik
2006-01-25 15:13 ` Jens Axboe
2006-01-25 15:12 ` Jeff Garzik
2006-01-25 15:16 ` Jens Axboe [this message]
[not found] <20060117105702.5e5a5cb5.randy_d_dunlap@linux.intel.com>
2006-01-24 9:07 ` Borislav Petkov
2006-01-24 13:08 ` Tejun Heo
2006-01-24 16:30 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060125151645.GF4212@suse.de \
--to=axboe@suse.de \
--cc=bbpetkov@yahoo.de \
--cc=bzolnier@gmail.com \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=randy_d_dunlap@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.