From: Andi Kleen <ak@muc.de>
To: Keith Owens <kaos@ocs.com.au>
Cc: Ashok Raj <ashok.raj@intel.com>,
akpm@osdl.org, linux-kernel@vger.kernel.org,
randy.d.dunlap@intel.com
Subject: Re: wrongly marked __init/__initdata for CPU hotplug
Date: 26 Jan 2006 05:28:48 +0100
Date: Thu, 26 Jan 2006 05:28:48 +0100 [thread overview]
Message-ID: <20060126042848.GB88680@muc.de> (raw)
In-Reply-To: <4496.1138242917@ocs3.ocs.com.au>
> This is nasty. init() calls do_basic_setup() which calls
> do_initcalls(). init is normal text. do_basic_setup and do_initcalls
> are .init.text. gcc has inlined do_basic_setup and do_initcalls into
> init, even though they have different section attributes. Naughty gcc.
>
> This was using GCC: (GNU) 4.0.2 20050901 (prerelease) (SUSE Linux).
> Log a gcc bug. Not a good omen for the idea of letting gcc decide when
> to inline!
Someone should file a bug in the gcc bugzilla then I guess.
Can you do that or should I?
>
> Looking at the C code for do_initcalls(), the reference is obviously to
> initcall_debug. I am puzzled about why the objdump lists
> .init.data+0x15b when initcall_debug is really at .init.data+0x164.
Ah thanks - ok i mislooked then. Anyways, it's not a bug.
> BTW, does anybody know why init() is not defined as __init?
Because it would crash then after returning from free_initmem.
-Andi
next prev parent reply other threads:[~2006-01-26 4:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-25 20:02 wrongly marked __init/__initdata for CPU hotplug Ashok Raj
2006-01-25 20:13 ` Andrew Morton
2006-01-25 21:48 ` Ashok Raj
2006-01-26 2:35 ` Keith Owens
2006-01-26 3:34 ` Ashok Raj
2006-01-26 4:28 ` Andi Kleen [this message]
2006-01-26 4:26 ` Andi Kleen
2006-01-27 1:36 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060126042848.GB88680@muc.de \
--to=ak@muc.de \
--cc=akpm@osdl.org \
--cc=ashok.raj@intel.com \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.d.dunlap@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.