From: Andi Kleen <ak@suse.de>
To: Ashok Raj <ashok.raj@intel.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, ak@muc.de,
ronald@hummelink.net, DiegoCG@teleline.es,
venkatesh.pallipadi@intel.com, anil.s.keshavamurthy@intel.com
Subject: Re: Dont record local apic ids when they are disabled in MADT
Date: Thu, 26 Jan 2006 15:34:54 +0100 [thread overview]
Message-ID: <200601261534.55620.ak@suse.de> (raw)
In-Reply-To: <20060126061034.A12261@unix-os.sc.intel.com>
On Thursday 26 January 2006 15:10, Ashok Raj wrote:
> On Thu, Jan 26, 2006 at 02:55:11PM +0100, Andi Kleen wrote:
> > On Thursday 26 January 2006 14:48, Ashok Raj wrote:
> > > Hi Andrew,
> > >
> > > We had added additional_cpus=xx for x86_64, but apparently there were some
> > > BIOSs that had duplicate apic ids when they were reported disabled.
> > >
> > > It seems fair not to record them, this was causing some bad behaviour due to
> > > the duplicate apic id. More details in the bugzilla recorded in the log.
> >
> > This means CPU hotplug will require additional non existing code again - or who
> > will set up the APIC IDs etc. for the new CPUs then?
>
>
> The ACPI hotplug code already would refresh this apic id when the notify
> for CPU hotplug is processed.
How? All the code who could do this is __init.
> (although i would say we tested this only on ia64 so far, the code is
> generic to x86_64 as well, but i havent gone around testing physical hotplug
> via emulation patches we have internally)
I doubt it will work on x86-64.
And you're breaking the CPU hotplug spec in Documentation/x86-64/cpu-hotplug-spec.
I think the BIOS bugs need to be workarounded without breaking that.
-Andi
next prev parent reply other threads:[~2006-01-26 14:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-26 13:48 Dont record local apic ids when they are disabled in MADT Ashok Raj
2006-01-26 13:55 ` Andi Kleen
2006-01-26 14:10 ` Ashok Raj
2006-01-26 14:34 ` Andi Kleen [this message]
2006-01-26 16:13 ` Ashok Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200601261534.55620.ak@suse.de \
--to=ak@suse.de \
--cc=DiegoCG@teleline.es \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=ashok.raj@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ronald@hummelink.net \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.