Re: udev_rules_get_run confusion

[Andrey Borzenkov <arvidjaar@mail.ru>]

[-- Attachment #1.1: Type: text/plain, Size: 332 bytes --]

On Thursday 26 January 2006 04:57, Kay Sievers wrote:
> On Wed, Jan 25, 2006 at 11:42:14PM +0300, Andrey Borzenkov wrote:
> > What this function does? As it is now it does *not* get called at all.
>

Oops I should never post that late. I missed this piece in previous patch. 
Trivial one-liner follows.

regards

-andrey

[-- Attachment #1.2: remove_apply_from_get_run.diff --]
[-- Type: text/x-diff, Size: 815 bytes --]

Subject: [PATCH] Remove udev_rules_apply_format from udev_rules_get_run

From: Andrey Borzenkov <arvidjaar@mail.ru>

This removes now redundant substitution (otherwise it will be expanded
twice).

Signed-off-by: Andrey Borzenkov <arvidjaar@mail.ru>
---

 udev_rules.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/udev_rules.c b/udev_rules.c
index 90dc024..5d68728 100644
--- a/udev_rules.c
+++ b/udev_rules.c
@@ -1082,7 +1082,6 @@ int udev_rules_get_run(struct udev_rules
 					name_list_cleanup(&udev->run_list);
 				}
 				strlcpy(program, key_val(rule, &rule->run), sizeof(program));
-				udev_rules_apply_format(udev, program, sizeof(program));
 				dbg("add run '%s'", program);
 				name_list_add(&udev->run_list, program, 0);
 				if (rule->run.operation == KEY_OP_ASSIGN_FINAL)

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]