From: Paul Jackson <pj@sgi.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: colpatch@us.ibm.com, bcrl@kvack.org, clameter@engr.sgi.com,
linux-kernel@vger.kernel.org, sri@us.ibm.com, andrea@suse.de,
pavel@suse.cz, linux-mm@kvack.org
Subject: Re: [patch 0/9] Critical Mempools
Date: Fri, 27 Jan 2006 02:10:50 -0800 [thread overview]
Message-ID: <20060127021050.f50d358d.pj@sgi.com> (raw)
In-Reply-To: <84144f020601262335g49c21b62qaa729732e9275c0@mail.gmail.com>
Pekka wrote:
> As as side note, we already have __GFP_NOFAIL. How is it different
> from GFP_CRITICAL and why aren't we improving that?
Don't these two flags invoke two different mechanisms.
__GFP_NOFAIL can sleep for HZ/50 then retry, rather than return failure.
__GFP_CRITICAL can steal from the emergency pool rather than fail.
I would favor renaming at least the __GFP_CRITICAL to something
like __GFP_EMERGPOOL, to highlight the relevant distinction.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.925.600.0401
WARNING: multiple messages have this Message-ID (diff)
From: Paul Jackson <pj@sgi.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: colpatch@us.ibm.com, bcrl@kvack.org, clameter@engr.sgi.com,
linux-kernel@vger.kernel.org, sri@us.ibm.com, andrea@suse.de,
pavel@suse.cz, linux-mm@kvack.org
Subject: Re: [patch 0/9] Critical Mempools
Date: Fri, 27 Jan 2006 02:10:50 -0800 [thread overview]
Message-ID: <20060127021050.f50d358d.pj@sgi.com> (raw)
In-Reply-To: <84144f020601262335g49c21b62qaa729732e9275c0@mail.gmail.com>
Pekka wrote:
> As as side note, we already have __GFP_NOFAIL. How is it different
> from GFP_CRITICAL and why aren't we improving that?
Don't these two flags invoke two different mechanisms.
__GFP_NOFAIL can sleep for HZ/50 then retry, rather than return failure.
__GFP_CRITICAL can steal from the emergency pool rather than fail.
I would favor renaming at least the __GFP_CRITICAL to something
like __GFP_EMERGPOOL, to highlight the relevant distinction.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.925.600.0401
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-01-27 10:11 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-25 19:39 [patch 0/9] Critical Mempools Matthew Dobson
2006-01-25 19:39 ` Matthew Dobson
2006-01-26 17:57 ` Christoph Lameter
2006-01-26 17:57 ` Christoph Lameter
2006-01-26 23:01 ` Matthew Dobson
2006-01-26 23:01 ` Matthew Dobson
2006-01-26 23:18 ` Christoph Lameter
2006-01-26 23:18 ` Christoph Lameter
2006-01-26 23:32 ` Matthew Dobson
2006-01-26 23:32 ` Matthew Dobson
2006-01-27 0:03 ` Benjamin LaHaise
2006-01-27 0:03 ` Benjamin LaHaise
2006-01-27 0:27 ` Matthew Dobson
2006-01-27 0:27 ` Matthew Dobson
2006-01-27 7:35 ` Pekka Enberg
2006-01-27 7:35 ` Pekka Enberg
2006-01-27 10:10 ` Paul Jackson [this message]
2006-01-27 10:10 ` Paul Jackson
2006-01-27 11:07 ` Pekka Enberg
2006-01-27 11:07 ` Pekka Enberg
2006-01-28 0:41 ` Matthew Dobson
2006-01-28 0:41 ` Matthew Dobson
2006-01-28 10:21 ` Pekka Enberg
2006-01-28 10:21 ` Pekka Enberg
2006-01-30 22:38 ` Matthew Dobson
2006-01-30 22:38 ` Matthew Dobson
2006-01-27 15:36 ` Jan Kiszka
2006-01-27 15:36 ` Jan Kiszka
2006-01-27 8:34 ` Sridhar Samudrala
2006-01-27 8:34 ` Sridhar Samudrala
2006-01-27 8:29 ` Sridhar Samudrala
2006-01-27 8:29 ` Sridhar Samudrala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060127021050.f50d358d.pj@sgi.com \
--to=pj@sgi.com \
--cc=andrea@suse.de \
--cc=bcrl@kvack.org \
--cc=clameter@engr.sgi.com \
--cc=colpatch@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pavel@suse.cz \
--cc=penberg@cs.helsinki.fi \
--cc=sri@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.