From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, Arjan van de Ven <arjan@infradead.org>
Subject: Re: [patch] warn on release_region() from irq context
Date: Sat, 28 Jan 2006 16:00:06 +0100 [thread overview]
Message-ID: <20060128150006.GA10660@elte.hu> (raw)
In-Reply-To: <20060128144357.GA6881@elte.hu>
the rationale for this patch is that the lock validator (which now
tracks rwlock dependencies too, see output below) noticed that floppy.c
does a release_region() from softirq context -> ouch. I'm working on the
floppy.c fix for that.
Ingo
============================
[ BUG: illegal lock usage! ]
----------------------------
illegal {softirq-on} -> {in-softirq} usage.
rcu_torture_rea/264 [HC0[0]:SC1[2]:HE1:SE0] takes:
(resource_lock){+-}, at: [<c0123997>] __release_region+0x37/0xf0
{softirq-on} state was registered at:
[<c0122c85>] irq_exit+0x45/0x50
hardirqs last enabled at: [<c011d39e>] vprintk+0x32e/0x3e0
softirqs last enabled at: [<c0122c85>] irq_exit+0x45/0x50
other info that might help us debug this:
no locks held by rcu_torture_rea/264.
stack backtrace:
[<c010432d>] show_trace+0xd/0x10
[<c0104347>] dump_stack+0x17/0x20
[<c0139078>] print_usage_bug+0x1d8/0x230
[<c0139436>] mark_lock+0x366/0x3a0
[<c0139903>] debug_lock_chain+0x493/0x1090
[<c013a53d>] debug_lock_chain_spin+0x3d/0x60
[<c0268522>] _raw_write_lock+0x32/0x1a0
[<c04dc158>] _write_lock+0x8/0x10
[<c0123997>] __release_region+0x37/0xf0
[<c02f5010>] floppy_release_irq_and_dma+0x140/0x200
[<c02f3577>] set_dor+0xc7/0x1b0
[<c02f65e1>] motor_off_callback+0x21/0x30
[<c01276c5>] run_timer_softirq+0xf5/0x1f0
[<c0122fc7>] __do_softirq+0x97/0x130
[<c01054a9>] do_softirq+0x69/0x100
=======================
[<c0122c85>] irq_exit+0x45/0x50
[<c010f504>] smp_apic_timer_interrupt+0x54/0x60
[<c010393b>] apic_timer_interrupt+0x27/0x2c
[<c0266b79>] __delay+0x9/0x10
[<c0266be1>] __udelay+0x31/0x40
[<c01445e3>] rcu_torture_reader+0x83/0x140
[<c0131cca>] kthread+0xca/0xd0
[<c0100ef5>] kernel_thread_helper+0x5/0x10
next prev parent reply other threads:[~2006-01-28 14:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-28 14:43 [patch] warn on release_region() from irq context Ingo Molnar
2006-01-28 15:00 ` Ingo Molnar [this message]
2006-01-28 16:02 ` Ingo Molnar
2006-01-29 13:06 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060128150006.GA10660@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.