Re: [Pcihpd-discuss] Re: [PATCH 0/7] acpiphp - slots management fix

[Greg KH <greg@kroah.com>]

On Sun, Jan 29, 2006 at 12:34:29PM +0900, MUNEDA Takahiro wrote:
> Hi,
> 
> At Thu, 26 Jan 2006 20:14:25 -0800,
> Greg KH <greg@kroah.com> wrote:
> > 
> > On Fri, Jan 20, 2006 at 07:08:30PM +0900, MUNEDA Takahiro wrote:
> > > Hi,
> > > 
> > > This series of patches contains slots management fix.
> > > Here are summary of changes:
> > > 
> > > o [PATCH 1/7] - removes unnecesary struct members
> > > 
> > > o [PATCH 2/7] - removes init_slots(), because acpiphp doesn't
> > >                 register slots when driver is loaded.
> > > 
> > > o [PATCH 3/7] - changes register_slot() to register hotplug
> > >                 slots when they are found
> > > 
> > > o [PATCH 4/7] - changes init_bridge_misc() to register hotplug
> > >                 slots when they are found
> > > 
> > > o [PATCH 5/7] - removes cleanup_slots(), because acpiphp
> > >                 doesn't unregister slots when driver is going
> > >                 to be un-loaded.
> > > 
> > > o [PATCH 6/7] - changes cleanup_brige() to unregister hotplug
> > >                 slots when acpiphp cleanup the bridge.
> > > 
> > > o [PATCH 7/7] - adds spin_lock/_unlock to protect slot_list
> > > 
> > > 
> > > For more specifc information, please see the header of each patch.
> > > These patches are against 2.6.16-rc1. I tested them on Tiger4.
> > 
> > This patch series does not even compile when applied:
> > 
> >   CC [M]  drivers/pci/hotplug/acpiphp_core.o
> > drivers/pci/hotplug/acpiphp_core.c: In function `acpiphp_register_hotplug_slot':
> > drivers/pci/hotplug/acpiphp_core.c:355: error: `hotplug_slot' undeclared (first use in this function)
> > drivers/pci/hotplug/acpiphp_core.c:355: error: (Each undeclared identifier is reported only once
> > drivers/pci/hotplug/acpiphp_core.c:355: error: for each function it appears in.)
> > drivers/pci/hotplug/acpiphp_core.c:359: error: `hotplug_slot_info' undeclared (first use in this function)
> > make[2]: *** [drivers/pci/hotplug/acpiphp_core.o] Error 1
> > 
> > Care to redo them?
> 
> 
> I'm sorry for my late replying.
> And thanks for your taking care of my patch.
> 
> At first, please let me introduce the base idea of this patch.
> I'm trying to support p2p bridge hotplug with acpiphp.
> 
>  Current acpiphp manages hotplug slot by ID. The ID is incremented
>  when acpiphp founds hotpluggable slots.
>  If the bridges(with hotpluggable slots) are hotplugged many times,
>  the hotpluggable slots are added many times also. The ID might be
>  overflowed. So this patch removes IDs to manage slots.
> 
>  And, this patch changes the slot register/unregister timing.
>  Current acpiphp registers the slots in the init_slots()
>  called from acpiphp_init(), and unregisters the slots in the
>  cleanup_slots() called from acpiphp_exit().
>  acpiphp doesn't assume the increase and decrease of the
>  hotpluggable slots.
>  This patch removes the slot register/unregister processes from the
>  init/exit phases. Instead, adds the these processes in the bridge
>  add/cleanup phases.
> 
> Currently, this change doesn't have any meanings. But these changes
> are needed to support p2p bridge(with hotplug slot) hotplug.
> 
> Here is an updated patch. Old patches were not need to be separated,
> so I merge them into below patch.
> 
> This patch is against 2.6.16-rc1-mm3. I tested them on Tiger4 and
> it works fine.

Ok, Kristen, have any objections to this patch?  I know it's in much the
same area that you are working in.

thanks,

greg k-h