From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: "Calin A. Culianu" <calin@ajvar.org>,
linux-kernel@vger.kernel.org, akpm@osdl.org,
Willy Tarreau <willy@w.ods.org>
Subject: Re: [PATCH] Watchdog: Winsystems EPX-C3 SBC
Date: Sun, 29 Jan 2006 17:47:26 -0600 [thread overview]
Message-ID: <20060129234726.GA20923@dmt.cnet> (raw)
In-Reply-To: <1137266649.23269.2.camel@localhost.localdomain>
On Sat, Jan 14, 2006 at 07:24:09PM +0000, Alan Cox wrote:
> Some quick comments:
>
> + if (len) {
> + epx_c3_pet();
> + }
>
> Doesn't need brackets (minor style)
>
> Otherwise it looks excellent but should use request_region and friends
> to claim the two ports it uses.
It misses locking to protect against two concurrent writers in case of
a shared /dev/wdt file-descriptor?
prev parent reply other threads:[~2006-01-30 3:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-14 2:59 [PATCH] Watchdog: Winsystems EPX-C3 SBC Calin A. Culianu
2006-01-14 19:24 ` Alan Cox
2006-01-14 20:08 ` Willy Tarreau
2006-01-29 23:47 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060129234726.GA20923@dmt.cnet \
--to=marcelo.tosatti@cyclades.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=calin@ajvar.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@w.ods.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.