From: Eric Wong <normalperson@yhbt.net>
To: Junio C Hamano <junkio@cox.net>
Cc: git list <git@vger.kernel.org>
Subject: [PATCH] rev-{list,parse}: allow -<n> as shorthand for --max-count=<n>
Date: Sun, 29 Jan 2006 16:28:02 -0800 [thread overview]
Message-ID: <20060130002802.GD15482@Muzzle> (raw)
In-Reply-To: <7v64o2kcym.fsf@assigned-by-dhcp.cox.net>
This will be enabled unless POSIXLY_CORRECT or POSIX_ME_HARDER is set
in the environment.
Some versions of head(1) and tail(1) allow their line limits to be
parsed this way. I find --max-count to be a commonly used option,
and also similar in spirit to head/tail, so I decided to make life
easier on my worn out (and lazy :) fingers with this patch.
Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
git-compat-util.h | 8 ++++++++
rev-list.c | 5 +++++
rev-parse.c | 4 ++++
3 files changed, 17 insertions(+), 0 deletions(-)
7a8d6dda7dacadc90377fc56d28d5d03493199c4
diff --git a/git-compat-util.h b/git-compat-util.h
index f982b8e..b2512ba 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -154,4 +154,12 @@ static inline int sane_case(int x, int h
#ifndef MAXPATHLEN
#define MAXPATHLEN 256
#endif
+
+static inline int posixly_correct(void)
+{
+ if (getenv("POSIXLY_CORRECT") || getenv("POSIX_ME_HARDER"))
+ return 1;
+ return 0;
+}
+
#endif
diff --git a/rev-list.c b/rev-list.c
index 4565755..f29d32a 100644
--- a/rev-list.c
+++ b/rev-list.c
@@ -749,6 +749,11 @@ int main(int argc, const char **argv)
struct commit *commit;
unsigned char sha1[20];
+ /* accept, -<digit>, like some versions of head/tail */
+ if (!posixly_correct() && (*arg == '-') && isdigit(arg[1])) {
+ max_count = atoi(arg + 1);
+ continue;
+ }
if (!strcmp(arg, "-n")) {
if (++i >= argc)
die("-n requires an argument");
diff --git a/rev-parse.c b/rev-parse.c
index 3c99a79..2966a33 100644
--- a/rev-parse.c
+++ b/rev-parse.c
@@ -53,6 +53,10 @@ static int is_rev_argument(const char *a
};
const char **p = rev_args;
+ /* accept, -<digit>, like some versions of head/tail */
+ if (!posixly_correct() && (*arg == '-') && isdigit(arg[1]))
+ return 1;
+
for (;;) {
const char *str = *p++;
int len;
--
1.1.5.ga7f5-dirty
next prev parent reply other threads:[~2006-01-30 0:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-24 7:29 [PATCH] rev-{list,parse}: allow -<n> as shorthand for --max-count=<n> Eric Wong
2006-01-24 8:02 ` Junio C Hamano
2006-01-25 6:33 ` Eric Wong
2006-01-25 9:52 ` Junio C Hamano
2006-01-29 13:40 ` [PATCH] rev-{list,parse}: allow -n<n> " Eric Wong
2006-01-29 13:47 ` [PATCH] rev-{list,parse}: optionally allow -<n> " Eric Wong
2006-01-29 20:15 ` Junio C Hamano
2006-01-30 0:28 ` Eric Wong [this message]
2006-01-29 20:15 ` [PATCH] rev-{list,parse}: allow -n<n> " Junio C Hamano
2006-01-30 0:25 ` Eric Wong
2006-01-30 0:26 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060130002802.GD15482@Muzzle \
--to=normalperson@yhbt.net \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.