From: Ralf Baechle <ralf@linux-mips.org>
To: Matt Porter <mporter@kernel.crashing.org>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] Fix vgacon oops on 64-bit
Date: Mon, 30 Jan 2006 18:17:54 +0000 [thread overview]
Message-ID: <20060130181754.GA29634@linux-mips.org> (raw)
In-Reply-To: <20060130083321.B3098@cox.net>
On Mon, Jan 30, 2006 at 08:33:21AM -0700, Matt Porter wrote:
> Although I'm not running a VGA card, I noticed this building
> a working malta 32-bit defconfig (vgacon enabled) for 64-bit.
> Without it, the vgacon probe will access unmapped space when
> looking to see if a vga card is present.
>
> Signed-off-by: Matt Porter <mporter@kernel.crashing.org>
>
> diff --git a/include/asm-mips/vga.h b/include/asm-mips/vga.h
> index ca5cec9..1390ab6 100644
> --- a/include/asm-mips/vga.h
> +++ b/include/asm-mips/vga.h
> @@ -13,7 +13,11 @@
> * access the videoram directly without any black magic.
> */
>
> +#ifdef CONFIG_64BIT
> +#define VGA_MAP_MEM(x) (0xffffffffb0000000UL + (unsigned long)(x))
> +#else
> #define VGA_MAP_MEM(x) (0xb0000000L + (unsigned long)(x))
> +#endif
Looks like driving out the devil with beelzebub. The 0xb0000000 address
is totally platform specific and nobody ever noticed ...
Ralf
next prev parent reply other threads:[~2006-01-30 18:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-30 15:33 [PATCH] Fix vgacon oops on 64-bit Matt Porter
2006-01-30 18:17 ` Ralf Baechle [this message]
2006-01-31 6:35 ` Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060130181754.GA29634@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=mporter@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.