From: Nigel Cunningham <ncunningham@cyclades.com>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: Yuki Cuss <celtic@sairyx.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pid: Don't hash pid 0.
Date: Mon, 30 Jan 2006 19:58:18 +1000 [thread overview]
Message-ID: <200601301958.24047.ncunningham@cyclades.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0601301047200.6405@yvahk01.tjqt.qr>
[-- Attachment #1: Type: text/plain, Size: 608 bytes --]
Hi.
On Monday 30 January 2006 19:49, Jan Engelhardt wrote:
> >> How about nr==0, it would make it more obvious.
> >
> > I am inclined to agree. `!nr' seems to imply some sort of an error
> > condition;
>
> ! seems to imply a boolean usually. (If this was Java, this would even
> be enforced.)
If this was Java! Thank goodness it's not :>
Nigel
> However, !x (and x) is scattered all around the kernel where
> x==0,x!=0 (or x==NULL,x!=NULL) would be more readable.
>
> > perhaps a comment could be placed in order to make why the case of (nr ==
> > 0) is being ignored.
> >
> > - Yuki.
>
> Jan Engelhardt
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2006-01-30 11:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-29 6:31 [PATCH] pid: Don't hash pid 0 Eric W. Biederman
2006-01-29 8:33 ` Andrew Morton
2006-01-29 10:04 ` Eric W. Biederman
2006-01-30 9:29 ` Jan Engelhardt
2006-01-30 9:44 ` Yuki Cuss
2006-01-30 9:49 ` Jan Engelhardt
2006-01-30 9:58 ` Nigel Cunningham [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-01-30 10:59 Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200601301958.24047.ncunningham@cyclades.com \
--to=ncunningham@cyclades.com \
--cc=akpm@osdl.org \
--cc=celtic@sairyx.org \
--cc=ebiederm@xmission.com \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.