* [KJ] [Patch 7/7] BUG_ON() Conversion in mm/vmalloc.c
@ 2006-01-31 13:03 Eric Sesterhenn / snakebyte
2006-01-31 13:45 ` Adrian Bunk
2006-01-31 14:53 ` Eric Sesterhenn / snakebyte
0 siblings, 2 replies; 3+ messages in thread
From: Eric Sesterhenn / snakebyte @ 2006-01-31 13:03 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 574 bytes --]
hi,
this changes if() BUG(); constructs to BUG_ON() which is
cleaner, contains unlikely() and can better optimized away.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.16-rc1-git4/mm/vmalloc.c.orig 2006-01-30 22:26:02.000000000 +0100
+++ linux-2.6.16-rc1-git4/mm/vmalloc.c 2006-01-30 22:26:56.000000000 +0100
@@ -321,8 +321,7 @@ void __vunmap(void *addr, int deallocate
int i;
for (i = 0; i < area->nr_pages; i++) {
- if (unlikely(!area->pages[i]))
- BUG();
+ BUG_ON(unlikely(!area->pages[i]));
__free_page(area->pages[i]);
}
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [KJ] [Patch 7/7] BUG_ON() Conversion in mm/vmalloc.c
2006-01-31 13:03 [KJ] [Patch 7/7] BUG_ON() Conversion in mm/vmalloc.c Eric Sesterhenn / snakebyte
@ 2006-01-31 13:45 ` Adrian Bunk
2006-01-31 14:53 ` Eric Sesterhenn / snakebyte
1 sibling, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2006-01-31 13:45 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 932 bytes --]
On Tue, Jan 31, 2006 at 02:03:29PM +0100, Eric Sesterhenn / snakebyte wrote:
> hi,
>
> this changes if() BUG(); constructs to BUG_ON() which is
> cleaner, contains unlikely() and can better optimized away.
>
> Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
>
> --- linux-2.6.16-rc1-git4/mm/vmalloc.c.orig 2006-01-30 22:26:02.000000000 +0100
> +++ linux-2.6.16-rc1-git4/mm/vmalloc.c 2006-01-30 22:26:56.000000000 +0100
> @@ -321,8 +321,7 @@ void __vunmap(void *addr, int deallocate
> int i;
>
> for (i = 0; i < area->nr_pages; i++) {
> - if (unlikely(!area->pages[i]))
> - BUG();
> + BUG_ON(unlikely(!area->pages[i]));
>...
You can drop the unlikely.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [KJ] [Patch 7/7] BUG_ON() Conversion in mm/vmalloc.c
2006-01-31 13:03 [KJ] [Patch 7/7] BUG_ON() Conversion in mm/vmalloc.c Eric Sesterhenn / snakebyte
2006-01-31 13:45 ` Adrian Bunk
@ 2006-01-31 14:53 ` Eric Sesterhenn / snakebyte
1 sibling, 0 replies; 3+ messages in thread
From: Eric Sesterhenn / snakebyte @ 2006-01-31 14:53 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 629 bytes --]
hi,
> > - if (unlikely(!area->pages[i]))
> > - BUG();
> > + BUG_ON(unlikely(!area->pages[i]));
> >...
>
> You can drop the unlikely.
of course... thanks.
Here is an updated patch
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.16-rc1-git4/mm/vmalloc.c.orig 2006-01-30 22:26:02.000000000 +0100
+++ linux-2.6.16-rc1-git4/mm/vmalloc.c 2006-01-30 22:26:56.000000000 +0100
@@ -321,8 +321,7 @@ void __vunmap(void *addr, int deallocate
int i;
for (i = 0; i < area->nr_pages; i++) {
- if (unlikely(!area->pages[i]))
- BUG();
+ BUG_ON(!area->pages[i]);
__free_page(area->pages[i]);
}
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-01-31 14:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-01-31 13:03 [KJ] [Patch 7/7] BUG_ON() Conversion in mm/vmalloc.c Eric Sesterhenn / snakebyte
2006-01-31 13:45 ` Adrian Bunk
2006-01-31 14:53 ` Eric Sesterhenn / snakebyte
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.