From: Dave Jones <davej@redhat.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix compile error in latest git pull - post 2.6.16-rc1-git4
Date: Tue, 31 Jan 2006 17:23:05 -0500 [thread overview]
Message-ID: <20060131222305.GE29937@redhat.com> (raw)
In-Reply-To: <43DFBA93.3090103@lwfinger.net>
On Tue, Jan 31, 2006 at 01:29:23PM -0600, Larry Finger wrote:
> After doing a git pull from linux/kernel/git/torvalds/linux-2.6.git, I get
> the following compiler error:
>
> CC net/ipv4/igmp.o
> net/ipv4/igmp.c: In function ‘igmp_rcv’:
> net/ipv4/igmp.c:973: error: label at end of compound statement
>
> Using git bisect, the patch that introduces this error is:
>
> c5d90e000437a463440c1fe039011a02583a9ee5 is first bad commit
> diff-tree c5d90e000437a463440c1fe039011a02583a9ee5 (from
> e2c2fc2c8f3750e1f7ffbb3ac2b885a49416110c)
> Author: Dave Jones <davej@redhat.com>
> Date: Mon Jan 30 20:27:17 2006 -0800
>
> [IPV4] igmp: remove pointless printk
>
> This is easily triggerable by sending bogus packets,
> allowing a malicious user to flood remote logs.
>
> Signed-off-by: Dave Jones <davej@redhat.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
>
> I suspect this error arises due to differences between gcc 4.0.2 and
> earlier releases. The patch is as follows:
Looks good.
Signed-off-by: Dave Jones <davej@redhat.com>
Dave
prev parent reply other threads:[~2006-01-31 22:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-31 19:29 [PATCH] Fix compile error in latest git pull - post 2.6.16-rc1-git4 Larry Finger
2006-01-31 22:23 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060131222305.GE29937@redhat.com \
--to=davej@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.