From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Date: Wed, 01 Feb 2006 10:24:27 +0000 Subject: Re: [patch 14/44] generic hweight{64,32,16,8}() Message-Id: <200602011124.29423.ak@suse.de> List-Id: References: <20060201090224.536581000@localhost.localdomain> <200602011006.09596.ak@suse.de> <43E07EB2.4020409@tls.msk.ru> In-Reply-To: <43E07EB2.4020409@tls.msk.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Michael Tokarev Cc: Akinobu Mita , linux-kernel@vger.kernel.org, Richard Henderson , Ivan Kokshaysky , Russell King , Ian Molton , dev-etrax@axis.com, David Howells , Yoshinori Sato , Linus Torvalds , linux-ia64@vger.kernel.org, Hirokazu Takata , linux-m68k@vger.kernel.org, Greg Ungerer , linux-mips@linux-mips.org, parisc-linux@parisc-linux.org, linuxppc-dev@ozlabs.org, linux390@de.ibm.com, linuxsh-dev@lists.sourceforge.net, linuxsh-shmedia-dev@lists.sourceforge.net, sparclinux@vger.kernel.org, ultralinux@vger.kernel.org, Miles Bader , Chris Zankel On Wednesday 01 February 2006 10:26, Michael Tokarev wrote: > Andi Kleen wrote: > > On Wednesday 01 February 2006 10:02, Akinobu Mita wrote: > > > >>+static inline unsigned int hweight32(unsigned int w) > [] > > How large are these functions on x86? Maybe it would be better to not inline them, > > but put it into some C file out of line. > > hweight8 47 bytes > hweight16 76 bytes > hweight32 97 bytes > hweight64 56 bytes (NOT inlining hweight32) > hweight64 197 bytes (inlining hweight32) > > Those are when compiled as separate non-inlined functions, > with pushl %ebp and ret. This would argue for moving them out of line. -Andi From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 01 Feb 2006 10:43:39 +0000 (GMT) Received: from cantor.suse.de ([195.135.220.2]:59810 "EHLO mx1.suse.de") by ftp.linux-mips.org with ESMTP id S8133648AbWBAKnV (ORCPT ); Wed, 1 Feb 2006 10:43:21 +0000 Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id 030B5E7D1; Wed, 1 Feb 2006 11:48:22 +0100 (CET) From: Andi Kleen To: Michael Tokarev Subject: Re: [patch 14/44] generic hweight{64,32,16,8}() Date: Wed, 1 Feb 2006 11:24:27 +0100 User-Agent: KMail/1.8.2 Cc: Akinobu Mita , linux-kernel@vger.kernel.org, Richard Henderson , Ivan Kokshaysky , Russell King , Ian Molton , dev-etrax@axis.com, David Howells , Yoshinori Sato , Linus Torvalds , linux-ia64@vger.kernel.org, Hirokazu Takata , linux-m68k@lists.linux-m68k.org, Greg Ungerer , linux-mips@linux-mips.org, parisc-linux@parisc-linux.org, linuxppc-dev@ozlabs.org, linux390@de.ibm.com, linuxsh-dev@lists.sourceforge.net, linuxsh-shmedia-dev@lists.sourceforge.net, sparclinux@vger.kernel.org, ultralinux@vger.kernel.org, Miles Bader , Chris Zankel References: <20060201090224.536581000@localhost.localdomain> <200602011006.09596.ak@suse.de> <43E07EB2.4020409@tls.msk.ru> In-Reply-To: <43E07EB2.4020409@tls.msk.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200602011124.29423.ak@suse.de> Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 10280 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ak@suse.de Precedence: bulk X-list: linux-mips On Wednesday 01 February 2006 10:26, Michael Tokarev wrote: > Andi Kleen wrote: > > On Wednesday 01 February 2006 10:02, Akinobu Mita wrote: > > > >>+static inline unsigned int hweight32(unsigned int w) > [] > > How large are these functions on x86? Maybe it would be better to not inline them, > > but put it into some C file out of line. > > hweight8 47 bytes > hweight16 76 bytes > hweight32 97 bytes > hweight64 56 bytes (NOT inlining hweight32) > hweight64 197 bytes (inlining hweight32) > > Those are when compiled as separate non-inlined functions, > with pushl %ebp and ret. This would argue for moving them out of line. -Andi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.suse.de (ns.suse.de [195.135.220.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx1.suse.de", Issuer "Thawte Premium Server CA" (verified OK)) by ozlabs.org (Postfix) with ESMTP id C4E1A689F3 for ; Wed, 1 Feb 2006 21:48:28 +1100 (EST) From: Andi Kleen To: Michael Tokarev Subject: Re: [patch 14/44] generic hweight{64,32,16,8}() Date: Wed, 1 Feb 2006 11:24:27 +0100 References: <20060201090224.536581000@localhost.localdomain> <200602011006.09596.ak@suse.de> <43E07EB2.4020409@tls.msk.ru> In-Reply-To: <43E07EB2.4020409@tls.msk.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Message-Id: <200602011124.29423.ak@suse.de> Cc: linux-mips@linux-mips.org, linux-ia64@vger.kernel.org, Ian Molton , David Howells , linuxppc-dev@ozlabs.org, Greg Ungerer , sparclinux@vger.kernel.org, Miles Bader , Yoshinori Sato , Hirokazu Takata , linuxsh-dev@lists.sourceforge.net, Linus Torvalds , Ivan Kokshaysky , Richard Henderson , Akinobu Mita , Chris Zankel , dev-etrax@axis.com, ultralinux@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org, linuxsh-shmedia-dev@lists.sourceforge.net, linux390@de.ibm.com, Russell King , parisc-linux@parisc-linux.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wednesday 01 February 2006 10:26, Michael Tokarev wrote: > Andi Kleen wrote: > > On Wednesday 01 February 2006 10:02, Akinobu Mita wrote: > > > >>+static inline unsigned int hweight32(unsigned int w) > [] > > How large are these functions on x86? Maybe it would be better to not inline them, > > but put it into some C file out of line. > > hweight8 47 bytes > hweight16 76 bytes > hweight32 97 bytes > hweight64 56 bytes (NOT inlining hweight32) > hweight64 197 bytes (inlining hweight32) > > Those are when compiled as separate non-inlined functions, > with pushl %ebp and ret. This would argue for moving them out of line. -Andi From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Date: Wed, 01 Feb 2006 10:24:27 +0000 Subject: Re: [patch 14/44] generic hweight{64,32,16,8}() Message-Id: <200602011124.29423.ak@suse.de> List-Id: References: <20060201090224.536581000@localhost.localdomain> <200602011006.09596.ak@suse.de> <43E07EB2.4020409@tls.msk.ru> In-Reply-To: <43E07EB2.4020409@tls.msk.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Michael Tokarev Cc: Akinobu Mita , linux-kernel@vger.kernel.org, Richard Henderson , Ivan Kokshaysky , Russell King , Ian Molton , dev-etrax@axis.com, David Howells , Yoshinori Sato , Linus Torvalds , linux-ia64@vger.kernel.org, Hirokazu Takata , linux-m68k@lists.linux-m68k.org, Greg Ungerer , linux-mips@linux-mips.org, parisc-linux@parisc-linux.org, linuxppc-dev@ozlabs.org, linux390@de.ibm.com, linuxsh-dev@lists.sourceforge.net, linuxsh-shmedia-dev@lists.sourceforge.net, sparclinux@vger.kernel.org, ultralinux@vger.kernel.org, Miles Bader , Chris Zankel On Wednesday 01 February 2006 10:26, Michael Tokarev wrote: > Andi Kleen wrote: > > On Wednesday 01 February 2006 10:02, Akinobu Mita wrote: > > > >>+static inline unsigned int hweight32(unsigned int w) > [] > > How large are these functions on x86? Maybe it would be better to not inline them, > > but put it into some C file out of line. > > hweight8 47 bytes > hweight16 76 bytes > hweight32 97 bytes > hweight64 56 bytes (NOT inlining hweight32) > hweight64 197 bytes (inlining hweight32) > > Those are when compiled as separate non-inlined functions, > with pushl %ebp and ret. This would argue for moving them out of line. -Andi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161010AbWBAKsZ (ORCPT ); Wed, 1 Feb 2006 05:48:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161014AbWBAKsZ (ORCPT ); Wed, 1 Feb 2006 05:48:25 -0500 Received: from ns1.suse.de ([195.135.220.2]:55970 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S1161010AbWBAKsX (ORCPT ); Wed, 1 Feb 2006 05:48:23 -0500 From: Andi Kleen To: Michael Tokarev Subject: Re: [patch 14/44] generic hweight{64,32,16,8}() Date: Wed, 1 Feb 2006 11:24:27 +0100 User-Agent: KMail/1.8.2 Cc: Akinobu Mita , linux-kernel@vger.kernel.org, Richard Henderson , Ivan Kokshaysky , Russell King , Ian Molton , dev-etrax@axis.com, David Howells , Yoshinori Sato , Linus Torvalds , linux-ia64@vger.kernel.org, Hirokazu Takata , linux-m68k@vger.kernel.org, Greg Ungerer , linux-mips@linux-mips.org, parisc-linux@parisc-linux.org, linuxppc-dev@ozlabs.org, linux390@de.ibm.com, linuxsh-dev@lists.sourceforge.net, linuxsh-shmedia-dev@lists.sourceforge.net, sparclinux@vger.kernel.org, ultralinux@vger.kernel.org, Miles Bader , Chris Zankel References: <20060201090224.536581000@localhost.localdomain> <200602011006.09596.ak@suse.de> <43E07EB2.4020409@tls.msk.ru> In-Reply-To: <43E07EB2.4020409@tls.msk.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200602011124.29423.ak@suse.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 01 February 2006 10:26, Michael Tokarev wrote: > Andi Kleen wrote: > > On Wednesday 01 February 2006 10:02, Akinobu Mita wrote: > > > >>+static inline unsigned int hweight32(unsigned int w) > [] > > How large are these functions on x86? Maybe it would be better to not inline them, > > but put it into some C file out of line. > > hweight8 47 bytes > hweight16 76 bytes > hweight32 97 bytes > hweight64 56 bytes (NOT inlining hweight32) > hweight64 197 bytes (inlining hweight32) > > Those are when compiled as separate non-inlined functions, > with pushl %ebp and ret. This would argue for moving them out of line. -Andi