From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Linux Kernel List <linux-kernel@vger.kernel.org>,
chris@zankel.net, lethal@linux-sh.org
Subject: Re: [BUG] sizeof(struct async_icount) exported to userspace on SH, SH64 and xtensa
Date: Thu, 2 Feb 2006 10:27:08 +0000 [thread overview]
Message-ID: <20060202102708.GD5034@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20060121185712.GA25185@flint.arm.linux.org.uk>
Ping?
On Sat, Jan 21, 2006 at 06:57:12PM +0000, Russell King wrote:
> I've just been looking through the remaining cruft in the serial
> drivers, and have come across this silly thing:
>
> TIOCGICOUNT exports a structure to userspace called
> struct serial_icounter_struct.
>
> However, sh, sh64 and xtensa do this:
>
> include/asm-sh/ioctls.h:#define TIOCGICOUNT _IOR('T', 93, struct async_icount) /* 0x545D */ /* read serial port inline interrupt counts */
> include/asm-sh64/ioctls.h:#define TIOCGICOUNT 0x802c545d /* _IOR('T', 93, struct async_icount) 0x545D */ /* read serial port inline interrupt counts */
> include/asm-xtensa/ioctls.h:#define TIOCGICOUNT _IOR('T', 93, struct async_icount) /* read serial port inline interrupt counts */
>
> What's more is that no driver actually exports async_icount, and
> async_icount is a kernel internal structure which does _not_ form
> part of the public API, and modifications to this will result in
> unexpected breakage on these platforms.
>
> 100% for trying to clean up the tty ioctl definitions. 0% for
> using the wrong structures. As such, these _require_ fixing.
>
> Please document that your TIOCGICOUNT is broken and remove the
> dependence on the async_icount structure. Thanks.
>
> --
> Russell King
> Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
> maintainer of: 2.6 Serial core
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2006-02-02 10:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-21 18:57 [BUG] sizeof(struct async_icount) exported to userspace on SH, SH64 and xtensa Russell King
2006-02-02 10:27 ` Russell King [this message]
2006-02-02 11:22 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060202102708.GD5034@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=chris@zankel.net \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.