From: Dave Jones <davej@redhat.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Chuck Ebbert <76306.1226@compuserve.com>,
ashok.raj@intel.com, linux-kernel@vger.kernel.org, pavel@ucw.cz
Subject: Re: [patch -mm4] i386 cpu hotplug: don't access freed memory
Date: Thu, 2 Feb 2006 20:33:57 -0500 [thread overview]
Message-ID: <20060203013357.GA10209@redhat.com> (raw)
In-Reply-To: <20060202165257.29dcfa20.akpm@osdl.org>
On Thu, Feb 02, 2006 at 04:52:57PM -0800, Andrew Morton wrote:
> Chuck Ebbert <76306.1226@compuserve.com> wrote:
> >
> > @@ -160,10 +162,17 @@ static void __cpuinit get_cpu_vendor(str
> > c->x86_vendor = i;
> > if (!early)
> > this_cpu = cpu_devs[i];
> > - break;
> > + return;
> > }
> > }
> > }
> > + if (!printed) {
> > + printed++;
> > + printk(KERN_ERR "CPU: Vendor unknown, using generic init.\n");
> > + printk(KERN_ERR "CPU: Your system may be unstable.\n");
> > + }
> > + c->x86_vendor = X86_VENDOR_UNKNOWN;
> > + this_cpu = &default_cpu;
>
> Well that's a worry. Under what circumstances (if any) will this final bit
> of code get executed?
Some new x86 CPU vendor appears that we don't know about.
Dave
next prev parent reply other threads:[~2006-02-03 1:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-03 0:00 [patch -mm4] i386 cpu hotplug: don't access freed memory Chuck Ebbert
2006-02-03 0:52 ` Andrew Morton
2006-02-03 1:33 ` Dave Jones [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-02-03 7:02 Chuck Ebbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060203013357.GA10209@redhat.com \
--to=davej@redhat.com \
--cc=76306.1226@compuserve.com \
--cc=akpm@osdl.org \
--cc=ashok.raj@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.