From: Al Viro <viro@ftp.linux.org.uk>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Olaf Hering <olh@suse.de>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
"Bryan O'Sullivan" <bos@pathscale.com>,
linux-kernel@vger.kernel.org, linux-m68k@vger.kernel.org
Subject: Re: [PATCH] Introduce __iowrite32_copy
Date: Fri, 3 Feb 2006 06:30:47 +0000 [thread overview]
Message-ID: <20060203063047.GX27946@ftp.linux.org.uk> (raw)
In-Reply-To: <20060202145720.GE22815@osiris.boeblingen.de.ibm.com>
On Thu, Feb 02, 2006 at 03:57:20PM +0100, Heiko Carstens wrote:
> > lib/iomap_copy.c: In function '__iowrite32_copy':
> > lib/iomap_copy.c:40: error: implicit declaration of function '__raw_writel'
> >
> > We compile with -Werror-implicit-function-declaration, and s390 does not
> > have a __raw_writel.
> > Should it just define __raw_writel to writel, like uml does a few
> > commits later?
>
> I sent a patch which fixes this for s390 earlier today.
> http://lkml.org/lkml/2006/2/2/78
Which leaves mips, m68k and sh64... For m68k cross-builds I've added
#define __raw_writel raw_outl in raw_io.h, but I'm not sure if m68k
folks are OK with that. Comments?
next prev parent reply other threads:[~2006-02-03 6:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200602011820.k11IKUBo024575@hera.kernel.org>
2006-02-02 14:29 ` [PATCH] Introduce __iowrite32_copy Olaf Hering
2006-02-02 14:57 ` Heiko Carstens
2006-02-02 16:49 ` Bryan O'Sullivan
2006-02-03 6:30 ` Al Viro [this message]
2006-02-03 8:34 ` Kars de Jong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060203063047.GX27946@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=bos@pathscale.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=olh@suse.de \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.