All of lore.kernel.org
 help / color / mirror / Atom feed
From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] [PATCH] I2C: add new rx8025 driver
Date: Fri, 03 Feb 2006 09:16:42 +0000	[thread overview]
Message-ID: <20060203101642.167cb18c.khali@linux-fr.org> (raw)
In-Reply-To: <20060201102335.GA8223@digi.com>

Hallo Uwe,

> Jean Delvare wrote:
> > Given that all block transfers you do are standard I2C block transfers,
> > you may consider switching to i2c_smbus_{read,write}_i2c_block_data for
> > SMBus compatibility. This would also make your code more simple, I
> > think.
>
> I don't understand how I specify the length of the block to be read for
> i2c_smbus_read_i2c_block_data.

Oops. This is a bug (or at least lack of fundamental feature) in the
current implementation of i2c_smbus_read_i2c_block_data. I want to fix
it for some times now but always postponed it due to the compatibility
issues it raises :(

So there is no way you can use i2c_smbus_read_i2c_block_data in your
driver at the moment; stick to i2c_transfer for now.

> (...) And i2c_smbus_xfer_emulated looks to me 
> as if it were not possible to use it when my adapter doesn't have
> algo->smbus_xfer.

Not correct. The i2c-core is able to emulate algo->smbus_xfer using
algo->master_xfer. See i2c_smbus_xfer() in i2c-core.c for the test, and
i2c_smbus_xfer_emulated() for the implementation.

-- 
Jean Delvare


  parent reply	other threads:[~2006-02-03  9:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-01 10:23 [lm-sensors] [PATCH] I2C: add new rx8025 driver Uwe Zeisberger
2006-02-01 19:23 ` Jean Delvare
2006-02-02  8:39 ` Uwe Zeisberger
2006-02-03  8:51 ` Uwe Zeisberger
2006-02-03  9:16 ` Jean Delvare [this message]
2006-02-03  9:43 ` Uwe Zeisberger
2006-02-03 13:43 ` Uwe Zeisberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060203101642.167cb18c.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.