All of lore.kernel.org
 help / color / mirror / Atom feed
From: Uwe_Zeisberger@digi.com (Uwe Zeisberger)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] new [PATCH] I2C: add new rx8025 driver
Date: Fri, 03 Feb 2006 13:42:26 +0000	[thread overview]
Message-ID: <20060203134225.GA4398@digi.com> (raw)

Hello Jean,

here comes a reworked driver (in a seperate e-mail to ease applying it).
I didn't implemented all your suggestions, as commented below.

I didn't (yet) used Alessandro's rtc core as it doesn't compile on
current HEAD.  (Moreover my driver has to work on 2.6.12.5, because
that's the version our customer has to stick to.)

You told me not to initialize a static global to NULL explicitly, I
thought about it and prefer to state this assumption just to make it
clear that I assume it to be zero.

Still open: I don't know if the mutex is needed.  I didn't see it in
other drivers but in my eyes it must be there.  Any comments?

I didn't switch over to smbus as you said in your follow-up mail[1].

I hope I catched all the remaining points to your satisfaction.

Best regards
Uwe

[1] Message-Id: <20060203101642.167cb18c.khali at linux-fr.org>

-- 
Uwe Zeisberger
FS Forth-Systeme GmbH, A Digi International Company
Kueferstrasse 8, D-79206 Breisach, Germany
Phone: +49 (7667) 908 0 Fax: +49 (7667) 908 200
Web: www.fsforth.de, www.digi.com


             reply	other threads:[~2006-02-03 13:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-03 13:42 Uwe Zeisberger [this message]
2006-03-04 16:02 ` [lm-sensors] new [PATCH] I2C: add new rx8025 driver Jean Delvare
2006-03-06  7:30 ` Uwe Zeisberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060203134225.GA4398@digi.com \
    --to=uwe_zeisberger@digi.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.