All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Paul Jackson <pj@sgi.com>
Cc: maule@sgi.com, linuxppc64-dev@ozlabs.org,
	linux-pci@atrey.karlin.mff.cuni.cz, linux-ia64@vger.kernel.org,
	linux-kernel@vger.kernel.org, tony.luck@intel.com,
	gregkh@suse.de
Subject: Re: Altix SN2 2.6.16-rc1-mm5 build breakage (was:  msi support)
Date: Sat, 04 Feb 2006 04:25:31 +0000	[thread overview]
Message-ID: <20060203202531.27d685fa.akpm@osdl.org> (raw)
In-Reply-To: <20060203201441.194be500.pj@sgi.com>

Paul Jackson <pj@sgi.com> wrote:
>
> The following patch seems to be breaking my ia64 sn2_defconfig
>  build of 2.6.16-rc1-mm5:
> 
>      gregkh-pci-altix-msi-support-git-ia64-fix.patch
> 
>  I'm guessing you should remove it for now.
> 
> 
>  Details:
>  ====
> 
>  When I try to build an ia64 sn2_defconfig 2.6.16-rc1-mm5, the
>  build fails:
> 
>      arch/ia64/sn/pci/tioce_provider.c:699:49: macro "ATE_MAKE" passed 3 arguments, but takes just 2
>      arch/ia64/sn/pci/tioce_provider.c: In function `tioce_reserve_m32':
>      arch/ia64/sn/pci/tioce_provider.c:699: error: `ATE_MAKE' undeclared (first use in this function)
> 
>  If I remove the patch:
> 
>      gregkh-pci-altix-msi-support-git-ia64-fix.patch
> 
>  then it compiles fine.

OK.  I autodrop several of Greg's MSI patches because a) they had bugs
which broke stuff a while ago and b) they don't apply and I'm lazy.  So it
looks like you've found a fix for a patch which isn't actually in -mm any
more.  I sent that fix to Greg the other day.

>  It seems that someone added a patchset to change the ATE_MAKE()
>  macro from 2 to 3 args, then someone added this above fix patch
>  for a missed change, then someone reverted it all back to 2 args,
>  but leaving this fix patch.
> 
>  I guess it means Andrew should remove the above patch.

I'll do that, thanks.


WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@osdl.org>
To: Paul Jackson <pj@sgi.com>
Cc: maule@sgi.com, linuxppc64-dev@ozlabs.org,
	linux-pci@atrey.karlin.mff.cuni.cz, linux-ia64@vger.kernel.org,
	linux-kernel@vger.kernel.org, tony.luck@intel.com,
	gregkh@suse.de
Subject: Re: Altix SN2 2.6.16-rc1-mm5 build breakage (was:  msi support)
Date: Fri, 3 Feb 2006 20:25:31 -0800	[thread overview]
Message-ID: <20060203202531.27d685fa.akpm@osdl.org> (raw)
In-Reply-To: <20060203201441.194be500.pj@sgi.com>

Paul Jackson <pj@sgi.com> wrote:
>
> The following patch seems to be breaking my ia64 sn2_defconfig
>  build of 2.6.16-rc1-mm5:
> 
>      gregkh-pci-altix-msi-support-git-ia64-fix.patch
> 
>  I'm guessing you should remove it for now.
> 
> 
>  Details:
>  ========
> 
>  When I try to build an ia64 sn2_defconfig 2.6.16-rc1-mm5, the
>  build fails:
> 
>      arch/ia64/sn/pci/tioce_provider.c:699:49: macro "ATE_MAKE" passed 3 arguments, but takes just 2
>      arch/ia64/sn/pci/tioce_provider.c: In function `tioce_reserve_m32':
>      arch/ia64/sn/pci/tioce_provider.c:699: error: `ATE_MAKE' undeclared (first use in this function)
> 
>  If I remove the patch:
> 
>      gregkh-pci-altix-msi-support-git-ia64-fix.patch
> 
>  then it compiles fine.

OK.  I autodrop several of Greg's MSI patches because a) they had bugs
which broke stuff a while ago and b) they don't apply and I'm lazy.  So it
looks like you've found a fix for a patch which isn't actually in -mm any
more.  I sent that fix to Greg the other day.

>  It seems that someone added a patchset to change the ATE_MAKE()
>  macro from 2 to 3 args, then someone added this above fix patch
>  for a missed change, then someone reverted it all back to 2 args,
>  but leaving this fix patch.
> 
>  I guess it means Andrew should remove the above patch.

I'll do that, thanks.


  reply	other threads:[~2006-02-04  4:25 UTC|newest]

Thread overview: 162+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-22 17:15 [PATCH 0/3] msi abstractions and support for altix Mark Maule
2005-12-22 17:15 ` Mark Maule
2005-12-22 17:15 ` [PATCH 1/3] msi vector targeting abstractions Mark Maule
2005-12-22 17:15   ` Mark Maule
2005-12-22 19:58   ` Greg KH
2005-12-22 19:58     ` Greg KH
2005-12-22 20:09     ` Mark Maule
2005-12-22 20:09       ` Mark Maule
2005-12-22 20:19       ` Greg KH
2005-12-22 20:19         ` Greg KH
2006-01-12 16:55   ` Joe Perches
2006-01-12 17:17   ` Greg KH
2006-01-14  7:34   ` Grant Grundler
2005-12-22 17:15 ` [PATCH 2/3] per-platform IA64_{FIRST,LAST}_DEVICE_VECTOR definitions Mark Maule
2005-12-22 17:15   ` Mark Maule
2005-12-22 20:01   ` Greg KH
2005-12-22 20:01     ` Greg KH
2005-12-22 20:06     ` Mark Maule
2005-12-22 20:06       ` Mark Maule
2005-12-22 17:15 ` [PATCH 2/3] altix: msi support Mark Maule
2005-12-22 17:15   ` Mark Maule
2005-12-22 20:15 ` [PATCH 0/3] msi abstractions and support for altix Mark Maule
2005-12-22 20:15   ` Mark Maule
2005-12-22 20:15   ` [PATCH 1/3] msi vector targeting abstractions Mark Maule
2005-12-22 20:15     ` Mark Maule
2006-01-03 22:39     ` Grant Grundler
2006-01-03 22:39       ` Grant Grundler
2006-01-03 23:50       ` Mark Maule
2006-01-03 23:50         ` Mark Maule
2006-01-04  0:20         ` Grant Grundler
2006-01-04  0:20           ` Grant Grundler
2006-01-04  0:27           ` Greg KH
2006-01-04  0:27             ` Greg KH
2006-01-04  3:52             ` Mark Maule
2006-01-04  3:52               ` Mark Maule
2005-12-22 20:15   ` [PATCH 2/3] per-platform IA64_{FIRST,LAST}_DEVICE_VECTOR definitions Mark Maule
2005-12-22 20:15     ` Mark Maule
2006-01-04  0:01     ` Grant Grundler
2006-01-04  0:01       ` Grant Grundler
2005-12-22 20:16   ` [PATCH 2/3] altix: msi support Mark Maule
2005-12-22 20:16     ` Mark Maule
2005-12-22 20:22   ` [PATCH 0/3] msi abstractions and support for altix Greg KH
2005-12-22 20:22     ` Greg KH
2005-12-22 20:26     ` Mark Maule
2005-12-22 20:26       ` Mark Maule
2005-12-22 20:34       ` Greg KH
2005-12-22 20:34         ` Greg KH
2005-12-22 20:38         ` Mark Maule
2005-12-22 20:38           ` Mark Maule
2005-12-22 20:50           ` Matthew Wilcox
2005-12-22 20:50             ` Matthew Wilcox
2006-01-03  3:22             ` Mark Maule
2006-01-03  3:22               ` Mark Maule
2006-01-03  6:07               ` Greg KH
2006-01-03  6:07                 ` Greg KH
2006-01-10 17:00                 ` Mark Maule
2006-01-10 17:00                   ` Mark Maule
2006-01-10 17:03                   ` Christoph Hellwig
2006-01-10 17:11                     ` Greg KH
2006-01-10 17:11                       ` Greg KH
2005-12-22 21:44           ` Greg KH
2005-12-22 21:44             ` Greg KH
2005-12-23 15:32             ` Mark Maule
2005-12-23 15:32               ` Mark Maule
2005-12-23 16:32               ` Greg KH
2005-12-23 16:32                 ` Greg KH
2006-01-11 15:52 ` Mark Maule
2006-01-11 15:52   ` Mark Maule
2006-01-11 15:52   ` [PATCH 1/3] msi vector targeting abstractions Mark Maule
2006-01-11 15:52     ` Mark Maule
2006-01-11 20:21     ` Greg KH
2006-01-11 20:21       ` Greg KH
2006-01-11 20:49       ` Mark Maule
2006-01-11 20:49         ` Mark Maule
2006-01-11 20:57         ` Greg KH
2006-01-11 20:57           ` Greg KH
2006-01-12  4:53     ` Grant Grundler
2006-01-12  5:02       ` Grant Grundler
2006-01-12  5:36       ` Greg KH
2006-01-12  5:36         ` Greg KH
2006-01-12  5:47       ` Paul Mackerras
2006-01-12  5:47         ` Paul Mackerras
2006-01-12  7:33         ` Grant Grundler
2006-01-12  7:33           ` Grant Grundler
2006-01-11 15:53   ` [PATCH 2/3] per-platform IA64_{FIRST,LAST}_DEVICE_VECTOR definitions Mark Maule
2006-01-11 15:53     ` Mark Maule
2006-01-11 15:53   ` [PATCH 2/3] altix: msi support Mark Maule
2006-01-11 15:53     ` Mark Maule
2006-01-11 22:16 ` [PATCH 0/3] msi abstractions and support for altix Mark Maule
2006-01-11 22:16   ` Mark Maule
2006-01-11 22:16   ` [PATCH 1/3] msi vector targeting abstractions Mark Maule
2006-01-11 22:16     ` Mark Maule
2006-01-11 22:16   ` [PATCH 2/3] per-platform IA64_{FIRST,LAST}_DEVICE_VECTOR definitions Mark Maule
2006-01-11 22:16     ` Mark Maule
2006-01-11 22:16   ` [PATCH 3/3] altix: msi support Mark Maule
2006-01-11 22:16     ` Mark Maule
2006-01-19 19:46 ` [PATCH 0/3] msi abstractions and support for altix Mark Maule
2006-01-19 19:46   ` Mark Maule
2006-01-19 19:46   ` [PATCH 1/3] msi vector targeting abstractions Mark Maule
2006-01-19 19:46     ` Mark Maule
2006-01-20  2:15     ` Greg KH
2006-01-20  2:15       ` Greg KH
2006-01-19 19:46   ` [PATCH 2/3] per-platform IA64_{FIRST,LAST}_DEVICE_VECTOR definitions Mark Maule
2006-01-19 19:46     ` Mark Maule
2006-01-19 19:47   ` [PATCH 3/3] altix: msi support Mark Maule
2006-01-19 19:47     ` Mark Maule
2006-02-04  4:14     ` Altix SN2 2.6.16-rc1-mm5 build breakage (was: msi support) Paul Jackson
2006-02-04  4:14       ` Paul Jackson
2006-02-04  4:25       ` Andrew Morton [this message]
2006-02-04  4:25         ` Andrew Morton
2006-02-04  4:27         ` Andrew Morton
2006-02-04  4:27           ` Andrew Morton
2006-02-04  4:42           ` Mark Maule
2006-02-04  4:42             ` Mark Maule
2006-02-04  5:08             ` Andrew Morton
2006-02-04  5:08               ` Andrew Morton
2006-02-23  0:50           ` Paul Jackson
2006-02-23  0:50             ` Paul Jackson
2006-02-23  1:01             ` Andrew Morton
2006-02-23  1:01               ` Andrew Morton
2006-03-21 14:34 ` [PATCH 0/3] msi abstractions and support for altix Mark Maule
2006-03-21 14:34   ` Mark Maule
2006-03-21 14:34   ` Mark Maule
2006-03-21 14:34   ` [PATCH 1/3] msi vector targeting abstractions Mark Maule
2006-03-21 14:34     ` Mark Maule
2006-03-21 14:34     ` Mark Maule
2006-03-21 16:29     ` Jun'ichi Nomura
2006-03-21 16:29       ` Jun'ichi Nomura
2006-03-21 16:29       ` Jun'ichi Nomura
2006-03-21 16:38       ` Andreas Schwab
2006-03-21 16:38         ` Andreas Schwab
2006-03-21 16:38         ` Andreas Schwab
2006-03-21 19:14         ` Mark Maule
2006-03-21 19:14           ` Mark Maule
2006-03-21 19:14           ` Mark Maule
2006-03-21 19:23           ` Jun'ichi Nomura
2006-03-21 19:23             ` Jun'ichi Nomura
2006-03-21 19:23             ` Jun'ichi Nomura
2006-03-21 19:38             ` Mark Maule
2006-03-21 19:38               ` Mark Maule
2006-03-21 19:38               ` Mark Maule
2006-03-21 14:34   ` [PATCH 2/3] per-platform IA64_{FIRST,LAST}_DEVICE_VECTOR definitions Mark Maule
2006-03-21 14:34     ` Mark Maule
2006-03-21 14:34     ` Mark Maule
2006-03-21 14:34   ` [PATCH 3/3] altix: msi support Mark Maule
2006-03-21 14:34     ` Mark Maule
2006-03-21 14:34     ` Mark Maule
2006-03-21 21:53   ` [PATCH 0/3] msi abstractions and support for altix David S. Miller
2006-03-21 21:53     ` David S. Miller
2006-03-21 21:53     ` David S. Miller
2006-03-29  2:31 ` Mark Maule
2006-03-29  2:31   ` Mark Maule
2006-03-29  2:31   ` Mark Maule
2006-03-29  2:31   ` [PATCH 1/3] msi vector targeting abstractions Mark Maule
2006-03-29  2:31     ` Mark Maule
2006-03-29  2:31     ` Mark Maule
2006-03-29  2:31   ` [PATCH 2/3] per-platform IA64_{FIRST,LAST}_DEVICE_VECTOR definitions Mark Maule
2006-03-29  2:31     ` Mark Maule
2006-03-29  2:31     ` Mark Maule
2006-03-29  2:31   ` [PATCH 3/3] altix: msi support Mark Maule
2006-03-29  2:31     ` Mark Maule
2006-03-29  2:31     ` Mark Maule

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060203202531.27d685fa.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=gregkh@suse.de \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=linuxppc64-dev@ozlabs.org \
    --cc=maule@sgi.com \
    --cc=pj@sgi.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.